From 2d4c8cf5c439e50afd3dc91e1042f65c35c5a859 Mon Sep 17 00:00:00 2001 From: SaeedZhiany Date: Wed, 12 Feb 2020 10:25:28 +0330 Subject: [PATCH] Load Android Gradle Plugin conditionally Also, bumped default gradle configs versions --- android/build.gradle | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index bc4cebc..7598ff5 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -3,25 +3,30 @@ def safeExtGet(prop, fallback) { } buildscript { - repositories { - google() - jcenter() - } + // The Android Gradle plugin is only required when opening the android folder stand-alone. + // This avoids unnecessary downloads and potential conflicts when the library is included as a + // module dependency in an application project. + if (project == rootProject) { + repositories { + google() + jcenter() + } - dependencies { - classpath 'com.android.tools.build:gradle:3.5.2' + dependencies { + classpath("com.android.tools.build:gradle:3.5.3") + } } } apply plugin: 'com.android.library' android { - compileSdkVersion safeExtGet('compileSdkVersion', 25) - buildToolsVersion safeExtGet('buildToolsVersion', '25.0.3') + compileSdkVersion safeExtGet('compileSdkVersion', 28) + buildToolsVersion safeExtGet('buildToolsVersion', '28.0.3') defaultConfig { minSdkVersion safeExtGet('minSdkVersion', 16) - targetSdkVersion safeExtGet('targetSdkVersion', 22) + targetSdkVersion safeExtGet('targetSdkVersion', 28) versionCode 1 versionName "1.0" @@ -34,7 +39,8 @@ android { } repositories { - mavenCentral() + google() + jcenter() } dependencies {