status-im
/
re-frame
mirror of https://github.com/status-im/re-frame.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #186 from oliyh/master 

Fix never-ending warn about not implementing IReactiveAtom
This commit is contained in:
Mike Thompson 2016-07-23 09:43:42 +10:00 committed by GitHub
parent 16585b2722 5daafa7db4
commit d9d02810a7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/re_frame/subs.cljs
View File

@ -79,7 +79,7 @@
(let [query-id (first-in-vector v) (let [query-id (first-in-vector v)
handler-fn (get @qid->fn query-id)] handler-fn (get @qid->fn query-id)]
(when ^boolean js/goog.DEBUG (when ^boolean js/goog.DEBUG
(when-let [not-reactive (remove #(implements? reagent.ratom/IReactiveAtom %) dynv)] (when-let [not-reactive (not-empty (remove #(implements? reagent.ratom/IReactiveAtom %) dynv))]
(console :warn "re-frame: your subscription's dynamic parameters that don't implement IReactiveAtom: " not-reactive))) (console :warn "re-frame: your subscription's dynamic parameters that don't implement IReactiveAtom: " not-reactive)))
(if (nil? handler-fn) (if (nil? handler-fn)
(console :error "re-frame: no subscription handler registered for: \"" query-id "\". Returning a nil subscription.") (console :error "re-frame: no subscription handler registered for: \"" query-id "\". Returning a nil subscription.")