From 5a78f6b5328d61c1e01500a773887d5a9773a211 Mon Sep 17 00:00:00 2001 From: led Date: Sun, 6 Sep 2015 15:59:58 +0100 Subject: [PATCH 1/4] typo in comment --- examples/todomvc/src/todomvc/handlers.cljs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/todomvc/src/todomvc/handlers.cljs b/examples/todomvc/src/todomvc/handlers.cljs index db6415b..0dcc4cb 100644 --- a/examples/todomvc/src/todomvc/handlers.cljs +++ b/examples/todomvc/src/todomvc/handlers.cljs @@ -41,7 +41,7 @@ ;; -- Handlers ---------------------------------------------------------------- ;; usage: (dispatch [:initialise-db]) -(register-handler ;; On app startup, ceate initial state +(register-handler ;; On app startup, create initial state :initialise-db ;; event id being handled check-schema-mw (fn [_ _] ;; the handler being registered From 8977fa2351643460f7cbca1e9d58c9d8b7d179d4 Mon Sep 17 00:00:00 2001 From: Daniel Compton Date: Mon, 7 Sep 2015 11:43:30 +1200 Subject: [PATCH 2/4] Revert "typo in comment" --- examples/todomvc/src/todomvc/handlers.cljs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/todomvc/src/todomvc/handlers.cljs b/examples/todomvc/src/todomvc/handlers.cljs index 0dcc4cb..db6415b 100644 --- a/examples/todomvc/src/todomvc/handlers.cljs +++ b/examples/todomvc/src/todomvc/handlers.cljs @@ -41,7 +41,7 @@ ;; -- Handlers ---------------------------------------------------------------- ;; usage: (dispatch [:initialise-db]) -(register-handler ;; On app startup, create initial state +(register-handler ;; On app startup, ceate initial state :initialise-db ;; event id being handled check-schema-mw (fn [_ _] ;; the handler being registered From 7806a6499b14fae68c2369aa54dbf16d61d588a6 Mon Sep 17 00:00:00 2001 From: Daniel Compton Date: Mon, 27 Jul 2015 19:28:52 +1200 Subject: [PATCH 3/4] Add CONTRIBUTING.md guidelines --- CONTRIBUTING.md | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 0000000..b579193 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,40 @@ +# Contributing to re-frame + +:+1::tada: First off, thanks for taking the time to contribute! :tada::+1: + +The following is a set of guidelines for contributing to re-frame which is hosted on [Github](https://github.com/Day8/re-frame). +These are just guidelines, not rules, use your best judgment and feel free to propose changes to this document in a pull request. + +## Creating issues for bugs + +Check if the issue has already been reported. If possible provide: + +* Version of re-frame being used +* Minimal reproduction steps + +## Creating issues for features + +Use your best judgement on what is needed here. + +## Pull requests + +**Create pull requests to the develop branch**, work will merged onto master when it is ready to be released. + +## Pull requests for bugs + +If possible provide: + +* Code that fixes the bug +* Failing tests which pass with the new changes +* Improvements to documentation to make it less likely that others will run into issues (if relevant). +* Add the change to the Unreleased section of [CHANGES.md](CHANGES.md) + +## Pull requests for features + +If possible provide: + +* Code that implements the new feature +* Tests to cover the new feature including all of the code paths +* Docstrings for functions +* Documentation examples +* Add the change to the Unreleased section of [CHANGES.md](CHANGES.md) From e803659a56c7cca574f2d9d88df79307a0e52581 Mon Sep 17 00:00:00 2001 From: Daniel Compton Date: Mon, 21 Sep 2015 14:47:53 +1200 Subject: [PATCH 4/4] Add clarification around usage of Github issues Support questions need to go to other places. --- CONTRIBUTING.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b579193..ce7cc6a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -5,6 +5,10 @@ The following is a set of guidelines for contributing to re-frame which is hosted on [Github](https://github.com/Day8/re-frame). These are just guidelines, not rules, use your best judgment and feel free to propose changes to this document in a pull request. +## Support questions + +**The Github issues for re-frame are for bug reports and feature requests. Support requests and usage questions should go to the [Clojure Slack channel](http://clojurians.net), the [ClojureScript mailing list](https://groups.google.com/forum/#!forum/clojurescript), or the [Reagent mailing list](https://groups.google.com/forum/#!forum/reagent-project).** + ## Creating issues for bugs Check if the issue has already been reported. If possible provide: