status-im/re-frame
2
0
Fork 0
mirror of https://github.com/status-im/re-frame.git synced 2025-02-24 07:48:14 +00:00
Code Issues Projects Releases Wiki Activity

Stop :name being accepted for Interceptors. Should be :id.

Browse Source 
`:name` was only ever valid for a short time during the alpha phases of 0.8.0
This commit is contained in:
Mike Thompson 2016-08-27 22:22:35 +10:00
parent bca5fd76db
commit 56de2a563e
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/re_frame/interceptor.cljc
View File

@ -15,12 +15,10 @@
(defn ->interceptor (defn ->interceptor
"Create an interceptor from named arguments" "Create an interceptor from named arguments"
[& {:as m :keys [name id before after]}] ;; XXX remove `name` in due course - only in there as a backwards compat thing [& {:as m :keys [id before after]}]
(when debug-enabled? (when debug-enabled?
(if name ;; XXX remove in due course
(console :warn "re-frame.core/->interceptor no longer takes `:name` - has been renamed to `:id`. Please change for " name))
(if-let [unknown-keys (seq (clojure.set/difference (if-let [unknown-keys (seq (clojure.set/difference
(-> (dissoc m :name) keys set) ;; XXX take out name in due course (-> m keys set)
mandatory-interceptor-keys))] mandatory-interceptor-keys))]
(console :error "re-frame: ->interceptor " m " has unknown keys:" unknown-keys))) (console :error "re-frame: ->interceptor " m " has unknown keys:" unknown-keys)))
{:id (or id name :unnamed) ;; XXX remove `name` in due course {:id (or id name :unnamed) ;; XXX remove `name` in due course