status-im
/
re-frame
mirror of https://github.com/status-im/re-frame.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Improve comments on router.

This commit is contained in:
mike-thompson-day8 2015-05-08 15:49:48 +10:00
parent 802d5142f8
commit 0aee218689
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/re_frame/router.cljs
View File

@ -44,12 +44,14 @@
(try
(handle event-v)
;; Unhandled exceptions from event handlers must be managed as follows:
;; - call the standard logging function "error"
;; - allow them to continue to bubble up because the app, in production,
;; If the handler throws:
;; - allow the exception to bubble up because the app, in production,
;; may have hooked window.onerror and perform special processing.
;; - But an exception which bubbles out will break the enclosing go-loop.
;; - But an exception which bubbles up will break the enclosing go-loop.
;; So we'll need to start another one.
;; - purge any pending events, because they are probably related to the
;; event which just fell in a screaming heap. Not sane to handle further
;; events if the prior event failed.
(catch js/Object e
(do
;; try to recover from this (probably uncaught) error as best we can