status-im
/
re-frame-10x
mirror of https://github.com/status-im/re-frame-10x.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Improve consistency of timing panel UI

This commit is contained in:
Daniel Compton 2018-02-13 15:32:14 +13:00
parent 125cc15fd2
commit d72d2bf0c7
2 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/day8/re_frame/trace/subs.cljs
View File

@ -382,7 +382,10 @@
:timing/event-handler event-handler-time :timing/event-handler event-handler-time
:timing/event-effects event-dofx-time :timing/event-effects event-dofx-time
:timing/event-interceptors remaining-interceptors :timing/event-interceptors remaining-interceptors
:timing/event-misc (- event-run-time event-time)}))) ;; TODO: look at splitting out interceptors from misc, there was a suspiciously high amount of time
;; in misc on some events, so that needs to be investigated.
; :timing/event-misc (- event-run-time event-time)
:timing/event-misc (- event-run-time event-handler-time event-dofx-time)})))
(rf/reg-sub (rf/reg-sub
:timing/render-time :timing/render-time

18
src/day8/re_frame/trace/view/timing.cljs
View File

@ -24,7 +24,8 @@
{:background-color common/disabled-background-color {:background-color common/disabled-background-color
:border (str "1px solid " common/border-line-color) :border (str "1px solid " common/border-line-color)
:font-weight "normal" :font-weight "normal"
:font-size "14px"}] :font-size "14px"
:width "63px"}]
[".timing-elapsed-panel" [".timing-elapsed-panel"
{:padding "12px" {:padding "12px"
@ -73,15 +74,19 @@
[rc/h-box [rc/h-box
:gap common/gs-12s :gap common/gs-12s
:class "timing-part-panel" :class "timing-part-panel"
:align :center
:children :children
[[:p "event" [:br] "processing"] [[rc/v-box
:align :center
:width common/gs-81s
:children [[:span "event"] [:span "processing"]]]
[timing-section "total" (:timing/event-total event-processing-time)] [timing-section "total" (:timing/event-total event-processing-time)]
[:span "="] [:span "="]
[timing-section "handler" (:timing/event-handler event-processing-time)] [timing-section "handler" (:timing/event-handler event-processing-time)]
[:span "+"] [:span "+"]
[timing-section "effects" (:timing/event-effects event-processing-time)] [timing-section "effects" (:timing/event-effects event-processing-time)]
[:span "+"] #_[:span "+"]
[timing-section "other int." (:timing/event-interceptors event-processing-time)] #_[timing-section "other int." (:timing/event-interceptors event-processing-time)]
[:span "+"] [:span "+"]
[timing-section "misc" (:timing/event-misc event-processing-time)] [timing-section "misc" (:timing/event-misc event-processing-time)]
@ -98,7 +103,10 @@
:class "timing-part-panel" :class "timing-part-panel"
:gap common/gs-12s :gap common/gs-12s
:children :children
[[:p "Animation" [:br] "frame" [:br] (str "#" frame)] [[rc/v-box
:align :center
:width common/gs-81s
:children [[:span "animation"] [:span "frame"] [:span "#" frame]]]
[timing-section "total" (:timing/animation-frame-total frame-time)] [timing-section "total" (:timing/animation-frame-total frame-time)]
[:span "="] [:span "="]
[timing-section "subs" (:timing/animation-frame-subs frame-time)] [timing-section "subs" (:timing/animation-frame-subs frame-time)]