From 46c90fb5045867a9b69f55ddb07f8834e0b5b4ba Mon Sep 17 00:00:00 2001 From: Gregg8 Date: Thu, 18 Jan 2018 13:03:21 +1100 Subject: [PATCH] Changed "ONLY BEFORE/AFTER" hyperlinks to open in a new page (and applied them to Subs page --- src/day8/re_frame/trace/view/app_db.cljs | 2 ++ src/day8/re_frame/trace/view/subs.cljs | 10 ++++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/day8/re_frame/trace/view/app_db.cljs b/src/day8/re_frame/trace/view/app_db.cljs index 4924b21..50d6aa8 100644 --- a/src/day8/re_frame/trace/view/app_db.cljs +++ b/src/day8/re_frame/trace/view/app_db.cljs @@ -247,6 +247,7 @@ :children [[rc/hyperlink-href ;:class "app-db-path--label" :label "ONLY BEFORE" + :target "_blank" :href "https://github.com/Day8/re-frame-trace/wiki/app-db#diff"]]] ^{:key "only-before-diff"} @@ -262,6 +263,7 @@ :children [[rc/hyperlink-href ;:class "app-db-path--label" :label "ONLY AFTER" + :target "_blank" :href "https://github.com/Day8/re-frame-trace/wiki/app-db#diff"]]] ^{:key "only-after-diff"} diff --git a/src/day8/re_frame/trace/view/subs.cljs b/src/day8/re_frame/trace/view/subs.cljs index 501fb7b..54dd8f2 100644 --- a/src/day8/re_frame/trace/view/subs.cljs +++ b/src/day8/re_frame/trace/view/subs.cljs @@ -195,10 +195,11 @@ :height common/gs-19s :justify :end :style {:margin (css-join "0px" pad-padding)} - :children [[rc/hyperlink + :children [[rc/hyperlink-href ;:class "app-db-path--label" :label "ONLY BEFORE" - :on-click #(println "Clicked [ONLY BEFORE]")]]]) + :target "_blank" + :href "https://github.com/Day8/re-frame-trace/wiki/app-db#diff"]]]) (when (and open? diff?) [rc/v-box :height "60px" @@ -212,10 +213,11 @@ :height common/gs-19s :justify :end :style {:margin (css-join "0px" pad-padding)} - :children [[rc/hyperlink + :children [[rc/hyperlink-href ;:class "app-db-path--label" :label "ONLY AFTER" - :on-click #(println "Clicked [ONLY AFTER]")]]]) + :target "_blank" + :href "https://github.com/Day8/re-frame-trace/wiki/app-db#diff"]]]) (when (and open? diff?) [rc/v-box :height "60px"