From 339d7c91470d29655a7db192385b00d578e946bc Mon Sep 17 00:00:00 2001 From: Daniel Compton Date: Tue, 30 Jan 2018 10:40:19 +1300 Subject: [PATCH] Add a docs link to layer ? subs --- src/day8/re_frame/trace/utils/re_com.cljs | 8 ++++++++ src/day8/re_frame/trace/view/subs.cljs | 16 +++++++--------- 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/src/day8/re_frame/trace/utils/re_com.cljs b/src/day8/re_frame/trace/utils/re_com.cljs index e34dbda..2b71f43 100644 --- a/src/day8/re_frame/trace/utils/re_com.cljs +++ b/src/day8/re_frame/trace/utils/re_com.cljs @@ -510,6 +510,14 @@ :align :start :child the-button])))) +(defn link [{:keys [label href]}] + [:a + {:rel "noopener noreferrer" + :class "rc-hyperlink-href noselect " + :href href + :target "_blank"} + label]) + (defn checkbox "I return the markup for a checkbox, with an optional RHS label" [& {:keys [model on-change label disabled? label-class label-style class style attr] diff --git a/src/day8/re_frame/trace/view/subs.cljs b/src/day8/re_frame/trace/view/subs.cljs index c08f861..a6cbcc1 100644 --- a/src/day8/re_frame/trace/view/subs.cljs +++ b/src/day8/re_frame/trace/view/subs.cljs @@ -91,14 +91,9 @@ :children [[rc/checkbox :model ignore-unchanged? ;; TODO: change from l2 subs to ignored l2 subs - :label [:span "Ignore " [:b {:style {:font-weight "700"}} @ignore-unchanged-l2-count] #_ " unchanged" [:br] "layer 2 subs " - - [:a - {:rel "noopener noreferrer" - :class "rc-hyperlink-href noselect " - :href "https://github.com/Day8/re-frame-trace/blob/master/docs/HyperlinkedInformation/UnchangedLayer2.md" - :target "_blank"} - "?"]] + :label [:span "Ignore " [:b {:style {:font-weight "700"}} @ignore-unchanged-l2-count] #_ " unchanged" [:br] + [rc/link {:label "layer 2 subs" + :href "https://github.com/Day8/re-frame-trace/blob/master/docs/HyperlinkedInformation/UnchangedLayer2.md"}]] :style {:margin-top "6px"} :on-change #(rf/dispatch [:subs/ignore-unchanged-subs? %])]]]]])) @@ -134,7 +129,10 @@ :model path :disabled? true]]] [rc/gap-f :size common/gs-12s] - [rc/label :label (str "Layer " (if (some? layer) layer "?"))] + [rc/label :label (if (some? layer) + (str "Layer " layer) + [rc/link {:label "Layer ?" + :href "https://github.com/Day8/re-frame-trace/blob/master/docs/HyperlinkedInformation/UnchangedLayer2.md#why-do-i-sometimes-see-layer--when-viewing-a-subscription"}])] ;; TODO: capture previous sub run value and allow diffing it. #_[rc/gap-f :size common/gs-12s]