status-im/re-frame-10x
2
0
Fork 0
mirror of https://github.com/status-im/re-frame-10x.git synced 2025-01-27 14:45:14 +00:00
Code Issues Projects Releases Wiki Activity

Parse input for duration filter correctly

Browse Source
This commit is contained in:
Saskia Lindner 2017-08-02 16:37:29 +02:00
parent b869ecc544
commit 2dde68256c
1 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/day8/re_frame/trace.cljs
View File

@ -142,7 +142,7 @@
(str/includes? (str/lower-case (str (:operation trace) " " (:op-type trace)))
(:query query)))
(fn [trace]
(< (js/parseInt (:query query)) (:duration trace)))))
(< (:query query) (:duration trace)))))
(defn render-traces [showing-traces]
(doall
@ -175,17 +175,23 @@
(defn render-trace-panel []
(let [filter-input (r/atom "")
filter-items (r/atom [])
filter-type (r/atom :contains)]
filter-type (r/atom :contains)
input-error (r/atom false)]
(fn []
(let [showing-traces (if (= @filter-items [])
@traces
(filter (apply every-pred (map query->fn @filter-items)) @traces))
save-query (fn [_]
(swap! filter-items conj {:id (random-uuid)
:query (if (= @filter-type :contains)
(str/lower-case @filter-input)
(js/parseInt @filter-input))
:filter-type @filter-type}))]
(if (and (= @filter-type :slower-than)
(js/isNaN (js/parseFloat @filter-input)))
(reset! input-error true)
(do
(reset! input-error false)
(swap! filter-items conj {:id (random-uuid)
:query (if (= @filter-type :contains)
(str/lower-case @filter-input)
(js/parseFloat @filter-input))
:filter-type @filter-type}))))]
[:div
[:div.filter-control {:style {:margin-bottom 20}}
[:div.filter-control-input
@ -200,6 +206,9 @@
[:button.button.icon-button {:on-click save-query
:style {:margin 0}}
[components/icon-add]]
(if @input-error
[:div.input-error {:style {:color "red" :margin-top 5}}
"Please enter a valid number."])
[:br]]
[:ul.filter-items
(map (fn [item]