From dab5d6aa943de89570842237599a50fa1ab3668b Mon Sep 17 00:00:00 2001
From: Pedro Pombeiro <pombeirp@users.noreply.github.com>
Date: Thu, 17 Jan 2019 22:17:56 +0100
Subject: [PATCH] Fix bot not updating check run if there are no annotations

---
 src/index.ts | 63 +++++++++++++++++++++++++++++-----------------------
 1 file changed, 35 insertions(+), 28 deletions(-)

diff --git a/src/index.ts b/src/index.ts
index 4c482e4..495e0ed 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -133,35 +133,14 @@ async function queueCheckAsync (context: Context, checkSuite: Octokit.ChecksCrea
 ${Humanize.boundedNumber(failures, 10)} ${Humanize.pluralize(failures, 'failure')}, ${Humanize.boundedNumber(warnings, 10)} ${Humanize.pluralize(warnings, 'warning')} in ${Humanize.oxford(uniqueProblemDependencies.map(f => `\`${f}\``), 3)} need your attention!`
     }
 
-    for (let annotationIndex = 0; annotationIndex < analysisResult.annotations.length; annotationIndex += 50) {
-      const annotationsSlice = analysisResult.annotations.length > 50 ? analysisResult.annotations.slice(annotationIndex, annotationIndex + 50) : analysisResult.annotations
+    if (analysisResult.annotations.length === 0) {
+      await updateRunAsync(context, check)
+    } else {
+      for (let annotationIndex = 0; annotationIndex < analysisResult.annotations.length; annotationIndex += 50) {
+        const annotationsSlice = analysisResult.annotations.length > 50 ? analysisResult.annotations.slice(annotationIndex, annotationIndex + 50) : analysisResult.annotations
 
-      convertAnnotationResults(check, annotationsSlice)
-
-      for (let attempts = 3; attempts >= 0;) {
-        try {
-          const updateResponse = await context.github.checks.update({
-            owner: check.owner,
-            repo: check.repo,
-            check_run_id: check.check_run_id,
-            name: check.name,
-            //details_url: check.details_url,
-            external_id: check.external_id,
-            started_at: check.started_at,
-            status: check.status,
-            conclusion: check.conclusion,
-            completed_at: check.completed_at,
-            output: check.output
-          })
-          context.log.debug(`update checks status: ${updateResponse.status}`)
-          break
-        } catch (error) {
-          if (--attempts <= 0) {
-            throw error
-          }
-          context.log.warn(`error while updating check run, will try again in 30 seconds: ${error.message}`)
-          await timeout(30000)
-        }
+        convertAnnotationResults(check, annotationsSlice)
+        await updateRunAsync(context, check)
       }
     }
     delete pendingChecks[head_sha]
@@ -171,6 +150,34 @@ ${Humanize.boundedNumber(failures, 10)} ${Humanize.pluralize(failures, 'failure'
   }
 }
 
+async function updateRunAsync(context: Context, check: Octokit.ChecksUpdateParams) {
+  for (let attempts = 3; attempts >= 0;) {
+    try {
+      const updateResponse = await context.github.checks.update({
+        owner: check.owner,
+        repo: check.repo,
+        check_run_id: check.check_run_id,
+        name: check.name,
+        //details_url: check.details_url,
+        external_id: check.external_id,
+        started_at: check.started_at,
+        status: check.status,
+        conclusion: check.conclusion,
+        completed_at: check.completed_at,
+        output: check.output
+      })
+      context.log.debug(`update checks status: ${updateResponse.status}`)
+      break
+    } catch (error) {
+      if (--attempts <= 0) {
+        throw error
+      }
+      context.log.warn(`error while updating check run, will try again in 30 seconds: ${error.message}`)
+      await timeout(30000)
+    }
+  }
+}
+
 async function checkPackageFileAsync (analysisResult: AnalysisResult, context: Context, filename: string, headSHA: string) {
   const contentsResponse: any = await context.github.repos.getContents(context.repo({
     path: filename,