status-im
/
packages-check-bot
mirror of https://github.com/status-im/packages-check-bot.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Make Go errors visible

This commit is contained in:
Pedro Pombeiro 2019-01-24 14:28:58 +01:00
parent a4a31b7e80
commit c2fc6f3698
No known key found for this signature in database
GPG Key ID: A65DEB11E4BBC647
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/dependency-check-gopkg.ts
View File

@ -179,14 +179,14 @@ export async function checkGoDependenciesAsync(
line,
}
const newAnnotation = (level: 'notice' | 'warning' | 'failure', message: string) => {
const title = `Dependency '${name}' is locked with ${dependency.rawRefType} '${dependency.refName}'.`
const title = `Dependency "${name}" is locked with ${dependency.rawRefType} '${dependency.refName}'.`
result.annotations.push(createAnnotation(annotation, level, title, message))
}
switch (refType) {
case 'tag':
continue
case 'commit':
newAnnotation('notice',
newAnnotation(name.startsWith('github.com/status-im/') ? 'warning' : 'notice',
`A commit SHA is not a deterministic dependency locator.
If the commit is overwritten by a force-push, it will be impossible to rebuild the same output in the future.
@ -194,7 +194,7 @@ Please lock the dependency with a tag/release.`,
)
break
case 'branch':
newAnnotation('notice', // TODO: change this to 'failure' once we've fixed issues in the codebase
newAnnotation('failure',
`A branch is not a deterministic dependency locator.
If the branch advances, it will be impossible to rebuild the same output in the future.