upgrade Node dependencies, including typescript
Also fix some error handling type issues. Signed-off-by: Jakub Sokołowski <jakub@status.im>
This commit is contained in:
parent
dffdedb97d
commit
6aa243a0dc
|
@ -19,7 +19,7 @@
|
|||
"smee-client": "^1.0.2",
|
||||
"ts-jest": "^24.0.0",
|
||||
"tslint": "^5.12.1",
|
||||
"typescript": "3.2.1",
|
||||
"typescript": "^4.5.4",
|
||||
"typescript-eslint-parser": "^18.0.0",
|
||||
"typescript-tslint-plugin": "^0.2.1"
|
||||
},
|
||||
|
|
|
@ -71,8 +71,11 @@ Pull requests: ${Humanize.oxford(checkSuite.pull_requests.map((pr) => pr.url), 5
|
|||
return createResponse
|
||||
}
|
||||
} catch (e) {
|
||||
/* Error of unknown type has to be handled */
|
||||
if (!(e instanceof Error)) {
|
||||
throw e
|
||||
}
|
||||
context.log.error(e)
|
||||
|
||||
// Report error back to GitHub
|
||||
check.status = 'completed'
|
||||
check.conclusion = 'cancelled'
|
||||
|
@ -286,7 +289,9 @@ async function updateRunAsync(context: Context, check: Octokit.ChecksUpdateParam
|
|||
if (--attempts <= 0) {
|
||||
throw error
|
||||
}
|
||||
context.log.warn(`error while updating check run, will try again in 30 seconds: ${error.message}`)
|
||||
if (error instanceof Error) {
|
||||
context.log.warn(`error while updating check run, will try again in 30 seconds: ${error.message}`)
|
||||
}
|
||||
await timeout(30000)
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue