status-im
/
open-bounty
mirror of https://github.com/status-im/open-bounty.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix outstanding issues with NonceTracker

This commit is contained in:
Martin Klepsch 2018-04-17 17:58:04 +02:00
parent 09cd9ec49a
commit c7b2f12c4f
No known key found for this signature in database
GPG Key ID: 1A35E702AD48A9F6
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/clj/commiteth/eth/core.clj
View File

@ -56,7 +56,13 @@
transactions (e.g. bounty contract deploy with same owner) shortly
after another. In this case web3j's TX counting only increases once
a transaction has been confirmed and so we send multiple identical
transactions with the same nonce."
transactions with the same nonce.
Web3j also provides a TransactionManager that increases nonces but it
does not track nonces related to transactions and so as far as I understand
it might cause transactions to be executed twice if they are retried.
https://github.com/web3j/web3j/blob/d19855475aa6620a7e93523bd9ede26ca50ed042/core/src/main/java/org/web3j/tx/RawTransactionManager.java"
(get-nonce [this internal-tx-id]
"Return the to be used nonce for an OpenBounty Ethereum
transaction identified by `internal-tx-id`. As these IDs are stable
@ -75,7 +81,7 @@
get
getTransactionCount)
nonce (if (contains? nonces web3j-tx-count)
(inc (max nonces))
(inc (apply max nonces))
web3j-tx-count)]
;; TODO this is a memory leak since tracking state is never pruned
;; Since we're not doing 1000s of transactions every day yet we can
@ -90,7 +96,7 @@
"Create a sign a raw transaction. 'From' argument is not needed as it's already encoded in credentials.
See https://web3j.readthedocs.io/en/latest/transactions.html#offline-transaction-signing"
(let [nonce (get-nonce nonce-tracker internal-tx-id)
tx (RawTransaction/createTransaction nonce gas-price gas-limit to data)
tx (RawTransaction/createTransaction (biginteger nonce) gas-price gas-limit to data)
signed (TransactionEncoder/signMessage tx (creds))
hex-string (Numeric/toHexString signed)]
(log/infof "Signing TX %s: nonce: %s, gas-price: %s, gas-limit: %s, data: %s"