op-geth/miner
Martin Holst Swende 9584f56b9d
miner: avoid sleeping in miner (#22108)
This PR removes a logic in the miner, which was originally intended to help temporary testnets based on ethash from "running off into the future". If the difficulty was low, and a few computers started mining several blocks per second, the ethash rules (which demand 1s delay between blocks) would push the blocktimes further and further away.
The solution was to make the miner sleep while this happened.

Nowadays, this problem is solved instead by PoA chains, and it's recommended to let testnets and devnets be based on clique instead. The existing logic is problematic, since it can cause stalls within the miner making it difficult for remote workers to submit work if the channel is blocked on a sleep.

Credits to Saar Tochner for reporting this via the bug bounty
2021-01-05 10:44:33 +01:00
..
miner.go miner: set etherbase even if mining isn't possible at the moment (#21707) 2020-10-14 11:59:11 +02:00
miner_test.go miner: fixed race condition in tests (#21664) 2020-10-20 10:58:26 +02:00
stress_clique.go node: refactor package node (#21105) 2020-08-03 19:40:46 +02:00
stress_ethash.go node: refactor package node (#21105) 2020-08-03 19:40:46 +02:00
unconfirmed.go all: replace RWMutex with Mutex in places where RLock is not used (#21622) 2020-10-13 10:58:41 +02:00
unconfirmed_test.go all: remove redundant conversions and import names (#21903) 2020-11-25 21:00:23 +01:00
worker.go miner: avoid sleeping in miner (#22108) 2021-01-05 10:44:33 +01:00
worker_test.go eth/downloader: fix spuriously failing tests (#21149) 2020-06-09 11:39:19 +02:00