op-geth

Commit Graph

Author	SHA1	Message	Date
Felix Lange	eb0e7b1b81	eth, p2p: remove EncodeMsg from p2p.MsgWriter ...and make it a top-level function instead. The original idea behind having EncodeMsg in the interface was that implementations might be able to encode RLP data to their underlying writer directly instead of buffering the encoded data. The encoder will buffer anyway, so that doesn't matter anymore. Given the recent problems with EncodeMsg (copy-pasted implementation bug) I'd rather implement once, correctly.	2015-01-06 12:23:38 +01:00
obscuren	6abf8ef78f	Merge	2015-01-05 17:10:42 +01:00
Felix Lange	da900f9435	p2p: add test for base protocol disconnect	2014-12-15 00:28:20 +01:00

Author

SHA1

Message

Date

Felix Lange

eb0e7b1b81

eth, p2p: remove EncodeMsg from p2p.MsgWriter

...and make it a top-level function instead.

The original idea behind having EncodeMsg in the interface was that
implementations might be able to encode RLP data to their underlying
writer directly instead of buffering the encoded data. The encoder
will buffer anyway, so that doesn't matter anymore.

Given the recent problems with EncodeMsg (copy-pasted implementation
bug) I'd rather implement once, correctly.

2015-01-06 12:23:38 +01:00

obscuren

6abf8ef78f

Merge

2015-01-05 17:10:42 +01:00

Felix Lange

da900f9435

p2p: add test for base protocol disconnect

2014-12-15 00:28:20 +01:00

3 Commits