Guillaume Ballet
9b831d74fb
accounts/usbwallet: fix a comment typo in trezor driver ( #19535 )
2019-05-07 19:22:24 +03:00
Kurkó Mihály
107c67d74e
accounts, cmd, internal, signer: add note about backing up the keystore ( #19432 )
...
* accounts: add note about backing up the keystore
* cmd, accounts: move the printout to accountCreate
* internal, signer: add info when new account is created via rpc
* cmd, internal, signer: split logs
* cmd/geth: make account new output a bit more verbose
2019-05-07 15:49:51 +03:00
Péter Szilágyi
7c91038bff
Merge pull request #19438 from karalabe/ledger-new-derivation-path
...
accounts: switch Ledger derivation path to canonical one
2019-04-25 13:33:17 +03:00
Péter Szilágyi
7221cb1434
core, eth, les, light: scope receipt functionality a bit cleaner
2019-04-15 13:42:26 +03:00
Guillaume Ballet
a1c5017bc5
accounts/scwallet: fix card pairing instruction message ( #19436 )
2019-04-10 13:46:35 +03:00
Péter Szilágyi
ae7344d799
accounts: switch Ledger derivation path to canonical one
2019-04-10 13:09:08 +03:00
Péter Szilágyi
8cf764da89
Revert "Can now specify the number of empty accounts to derive"
...
This reverts commit 5b30aa59d6
.
2019-04-10 12:51:22 +03:00
Guillaume Ballet
f0b878d56d
accounts/scwallet: Update README for v2.2.1 support ( #19425 )
...
Update the app download link to the latest version, as requested in #19418
2019-04-10 10:51:45 +02:00
Guillaume Ballet
5b30aa59d6
Can now specify the number of empty accounts to derive
2019-04-08 13:21:22 +02:00
Guillaume Ballet
6f21520a82
More review feedback
2019-04-08 13:21:22 +02:00
Guillaume Ballet
fc3000d649
more review feedback
2019-04-08 13:21:22 +02:00
Guillaume Ballet
d2daff4258
fix a serialization error
2019-04-08 13:21:22 +02:00
Martin Holst Swende
aae61ab16e
Apply suggestions from code review
...
Co-Authored-By: gballet <gballet@gmail.com>
2019-04-08 13:21:22 +02:00
Martin Holst Swende
df5409c952
'sanitize' JSON input
...
Co-Authored-By: gballet <gballet@gmail.com>
2019-04-08 13:21:22 +02:00
Guillaume Ballet
3b3e1bc07e
Update the card preparation instructions based on review feedback
2019-04-08 13:21:22 +02:00
Guillaume Ballet
8c786a1f99
refresh the account list when initializing the card
2019-04-08 13:21:22 +02:00
Guillaume Ballet
79f4cfac2e
refuse to overwrite the master key of a previously initialized card
2019-04-08 13:21:22 +02:00
Guillaume Ballet
1d1bee528e
fix unnecessary condition linter warning
2019-04-08 13:21:22 +02:00
Guillaume Ballet
714675cd2a
Upgrade to keycard app v2.1.1
2019-04-08 13:21:22 +02:00
Guillaume Ballet
35b80f1865
Fix linter issues
2019-04-08 13:21:22 +02:00
Guillaume Ballet
bcf3c52ac9
PK derivation has to be supported by the card
2019-04-08 13:21:22 +02:00
Guillaume Ballet
189a032987
Add instructions on how to install the card
2019-04-08 13:21:22 +02:00
Guillaume Ballet
ec4fba83d4
Formatting fixes
2019-04-08 13:21:22 +02:00
Guillaume Ballet
21b01f590d
Update a comment to reflect the workings of the updated system
2019-04-08 13:21:22 +02:00
Guillaume Ballet
9b66a8520a
Add some documentation
2019-04-08 13:21:22 +02:00
Guillaume Ballet
e273031dce
Fix key derivation
2019-04-08 13:21:22 +02:00
Guillaume Ballet
7ec6fa03d3
fix wallet status update
...
This is a temporary fix, better checks need to
be performed once the whole process has been
validated.
2019-04-08 13:21:22 +02:00
Guillaume Ballet
42c76a2ba1
Temporary fix to the ADBU status call
2019-04-08 13:21:22 +02:00
Guillaume Ballet
5617dca1c9
Remove the direct dependency on libpcsclite
...
Instead, use a go library that communicates with pcscd over a socket.
Also update the changes introduced by @gravityblast since this PR's
inception
2019-04-08 13:21:22 +02:00
Guillaume Ballet
ae82c58631
Fix some linter issues
2019-04-08 13:19:37 +02:00
Guillaume Ballet
7b230b7ef1
accounts/scwallet: rebase and update
2019-04-08 13:19:37 +02:00
Péter Szilágyi
a900e80a89
accounts/scwallet: fix crypto API change
2019-04-08 13:19:37 +02:00
Péter Szilágyi
7d5886dcf4
accounts, console: frendly card errors, support pin unblock
2019-04-08 13:19:37 +02:00
Péter Szilágyi
386943943f
accounts/scwallet: ordered wallets, tighter events, derivation logs
2019-04-08 13:19:37 +02:00
Péter Szilágyi
114de0fe2a
accounts/scwallet, console: user friendly card opening
2019-04-08 13:19:37 +02:00
Nick Johnson
78375608a4
accounts, internal: Changes in response to review
2019-04-08 13:19:37 +02:00
Nick Johnson
f7027dd68c
accounts, core, internal, node: Add support for smartcard wallets
2019-04-08 13:19:37 +02:00
gary rong
d5cae48bae
accounts, cmd, internal: disable unlock account on open HTTP ( #17037 )
...
* cmd, accounts, internal, node, rpc, signer: insecure unlock protect
* all: strict unlock API by rpc
* cmd/geth: check before printing warning log
* accounts, cmd/geth, internal: tiny polishes
2019-04-04 14:03:10 +03:00
Ian Norden
cd79bc61a9
accounts/abi: generic unpacking of event logs into map[string]interface{} ( #18440 )
...
Add methods that allow for the unpacking of event logs into maps (allows for agnostic unpacking of logs)
2019-04-01 15:42:59 +02:00
Mats Julian Olsen
5b0d3fa393
accounts/abi: Add the original name as json-structtag for tuples.
2019-03-28 14:32:09 +01:00
Péter Szilágyi
5ce192ce44
accounts/abi/bind: simulated test case for fixed bytes logs
2019-03-14 12:58:18 +02:00
Jeremy McNevin
7640c9c933
bind: Static byte arrays should be right-padded
...
Per https://solidity.readthedocs.io/en/v0.5.3/abi-spec.html :
"bytes<M>: enc(X) is the sequence of bytes in X padded with trailing zero-bytes to a length of 32 bytes"
2019-03-14 12:51:10 +02:00
Corey Lin
2fa9e99fc1
usbwallet: check error returned by driver close ( #18057 )
...
Although current two implementations(ledgerDriver, trezorDriver) of interface driver.Close do not actually return any error. Instead, they only return nil.
But since the declaration of Close function returns error, it is better to check the returned error in case in future some new implementation of Close function returns error and we may forget to modify the function which invokes Close function at that time.
2019-03-07 12:13:06 +02:00
Péter Szilágyi
054412e335
all: clean up and proerly abstract database access
2019-03-06 13:35:03 +02:00
Matthew Halpern
15eee47ebf
accounts: prefer nil slices over zero-length slices ( #19079 )
2019-03-06 12:30:39 +02:00
Dan Kinsley
f49f95e2b0
accounts/abi: mutex lock in TransactionByHash and code cleanup ( #19133 )
2019-02-20 08:08:54 +01:00
Hsien-Tang Kao
4a090a1bab
accounts/abi: fix error message format ( #19122 )
2019-02-19 10:34:55 +02:00
Guillaume Ballet
9c7e65c435
accounts: fix typos from the `SignData` merge ( #19119 )
2019-02-19 10:33:42 +02:00
Dan Kinsley
555b3652dc
accounts/abi/bind/backends: add TransactionByHash to SimulatedBackend ( #19026 )
2019-02-13 00:23:10 +01:00
Martin Holst Swende
75d292bcf6
clef: external signing fixes + signing data ( #19003 )
...
* signer/clef: make use of json-rpc notification
* signer: tidy up output of OnApprovedTx
* accounts/external, signer: implement remote signing of text, make accounts_sign take hexdata
* clef: added basic testscript
* signer, external, api: add clique signing test to debug rpc, fix clique signing in clef
* signer: fix clique interoperability between geth and clef
* clef: rename networkid switch to chainid
* clef: enable chainid flag
* clef, signer: minor changes from review
* clef: more tests for signer
2019-02-12 14:00:02 +01:00