mirror of https://github.com/status-im/op-geth.git
swarm/storage: fix loop bound for database cleanup (#19085)
The current loop continuation condition is always true as a uint8 is always being checked whether it is less than 255 (its maximum value). Since the loop starts with the value 1, the loop termination can be guarranteed to exit once the value overflows to 0.
This commit is contained in:
parent
9d5e10f5bb
commit
fbedf62f3d
|
@ -527,8 +527,8 @@ func (s *LDBStore) Cleanup(f func(*chunk) bool) {
|
|||
if err != nil {
|
||||
found := false
|
||||
|
||||
// highest possible proximity is 255
|
||||
for po = 1; po <= 255; po++ {
|
||||
// The highest possible proximity is 255, so exit loop upon overflow.
|
||||
for po = uint8(1); po != 0; po++ {
|
||||
datakey = getDataKey(index.Idx, po)
|
||||
data, err = s.db.Get(datakey)
|
||||
if err == nil {
|
||||
|
|
Loading…
Reference in New Issue