status-im/op-geth
2
0
Fork 0
mirror of https://github.com/status-im/op-geth.git synced 2025-02-04 10:54:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Getters shouldn't need to be pointer receiver

Browse Source
This commit is contained in:
obscuren 2015-03-16 16:44:27 +01:00
parent 0dd9ac375b
commit 76f215b0fe
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
common/types.go
View File

@ -1,9 +1,6 @@
package common package common
type ( type Hash [32]byte
Hash [32]byte
Address [20]byte
)
var ( var (
zeroHash Hash zeroHash Hash
@ -27,7 +24,7 @@ func StringToAddress(s string) Address { return BytesToAddress([]byte(s)) }
// Don't use the default 'String' method in case we want to overwrite // Don't use the default 'String' method in case we want to overwrite
// Get the string representation of the underlying hash // Get the string representation of the underlying hash
func (h *Hash) Str() string { func (h Hash) Str() string {
return string(h[:]) return string(h[:])
} }
@ -53,13 +50,15 @@ func (h *Hash) Set(other Hash) {
} }
} }
type Address [20]byte
// Get the string representation of the underlying address // Get the string representation of the underlying address
func (a Address) Str() string { func (a Address) Str() string {
return string(a[:]) return string(a[:])
} }
// Sets the address to the value of b. If b is larger than len(a) it will panic // Sets the address to the value of b. If b is larger than len(a) it will panic
func (a Address) SetBytes(b []byte) { func (a *Address) SetBytes(b []byte) {
if len(b) > len(a) { if len(b) > len(a) {
panic("unable to set bytes. too big") panic("unable to set bytes. too big")
} }
@ -71,10 +70,10 @@ func (a Address) SetBytes(b []byte) {
} }
// Set string `s` to a. If s is larger than len(a) it will panic // Set string `s` to a. If s is larger than len(a) it will panic
func (a Address) SetString(s string) { a.SetBytes([]byte(s)) } func (a *Address) SetString(s string) { a.SetBytes([]byte(s)) }
// Sets a to other // Sets a to other
func (a Address) Set(other Address) { func (a *Address) Set(other Address) {
for i, v := range other { for i, v := range other {
a[i] = v a[i] = v
} }