status-im
/
op-geth
mirror of https://github.com/status-im/op-geth.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

eth, p2p: rename trusted nodes to static, drop inbound extra slots

This commit is contained in:
Péter Szilágyi 2015-04-30 19:32:48 +03:00
parent 701591b403
commit 413ace37d3
5 changed files with 59 additions and 57 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
eth/backend.go
View File

@ -41,8 +41,8 @@ var (
discover.MustParseNode("enode://487611428e6c99a11a9795a6abe7b529e81315ca6aad66e2a2fc76e3adf263faba0d35466c2f8f68d561dbefa8878d4df5f1f2ddb1fbeab7f42ffb8cd328bd4a@5.1.83.226:30303"), discover.MustParseNode("enode://487611428e6c99a11a9795a6abe7b529e81315ca6aad66e2a2fc76e3adf263faba0d35466c2f8f68d561dbefa8878d4df5f1f2ddb1fbeab7f42ffb8cd328bd4a@5.1.83.226:30303"),
} }
// Path within <datadir> to search for the trusted node list // Path within <datadir> to search for the static node list
trustedNodes = "trusted-nodes.json" staticNodes = "static-nodes.json"
) )
type Config struct { type Config struct {
@ -102,23 +102,23 @@ func (cfg *Config) parseBootNodes() []*discover.Node {
return ns return ns
} }
// parseTrustedNodes parses a list of discovery node URLs either given literally, // parseStaticNodes parses a list of discovery node URLs either given literally,
// or loaded from a .json file. // or loaded from a .json file.
func (cfg *Config) parseTrustedNodes() []*discover.Node { func (cfg *Config) parseStaticNodes() []*discover.Node {
// Short circuit if no trusted node config is present // Short circuit if no static node config is present
path := filepath.Join(cfg.DataDir, trustedNodes) path := filepath.Join(cfg.DataDir, staticNodes)
if _, err := os.Stat(path); err != nil { if _, err := os.Stat(path); err != nil {
return nil return nil
} }
// Load the trusted nodes from the config file // Load the static nodes from the config file
blob, err := ioutil.ReadFile(path) blob, err := ioutil.ReadFile(path)
if err != nil { if err != nil {
glog.V(logger.Error).Infof("Failed to access trusted nodes: %v", err) glog.V(logger.Error).Infof("Failed to access static nodes: %v", err)
return nil return nil
} }
nodelist := []string{} nodelist := []string{}
if err := json.Unmarshal(blob, &nodelist); err != nil { if err := json.Unmarshal(blob, &nodelist); err != nil {
glog.V(logger.Error).Infof("Failed to load trusted nodes: %v", err) glog.V(logger.Error).Infof("Failed to load static nodes: %v", err)
return nil return nil
} }
// Interpret the list as a discovery node array // Interpret the list as a discovery node array
@ -129,7 +129,7 @@ func (cfg *Config) parseTrustedNodes() []*discover.Node {
} }
node, err := discover.ParseNode(url) node, err := discover.ParseNode(url)
if err != nil { if err != nil {
glog.V(logger.Error).Infof("Trusted node URL %s: %v\n", url, err) glog.V(logger.Error).Infof("Static node URL %s: %v\n", url, err)
continue continue
} }
nodes = append(nodes, node) nodes = append(nodes, node)
@ -288,7 +288,7 @@ func New(config *Config) (*Ethereum, error) {
NAT: config.NAT, NAT: config.NAT,
NoDial: !config.Dial, NoDial: !config.Dial,
BootstrapNodes: config.parseBootNodes(), BootstrapNodes: config.parseBootNodes(),
TrustedNodes: config.parseTrustedNodes(), StaticNodes: config.parseStaticNodes(),
NodeDatabase: nodeDb, NodeDatabase: nodeDb,
} }
if len(config.Port) > 0 { if len(config.Port) > 0 {

14
p2p/handshake.go
View File

@ -70,21 +70,21 @@ type protoHandshake struct {
// If dial is non-nil, the connection the local node is the initiator. // If dial is non-nil, the connection the local node is the initiator.
// If atcap is true, the connection will be disconnected with DiscTooManyPeers // If atcap is true, the connection will be disconnected with DiscTooManyPeers
// after the key exchange. // after the key exchange.
func setupConn(fd net.Conn, prv *ecdsa.PrivateKey, our *protoHandshake, dial *discover.Node, atcap bool, trust map[discover.NodeID]bool) (*conn, error) { func setupConn(fd net.Conn, prv *ecdsa.PrivateKey, our *protoHandshake, dial *discover.Node, atcap bool) (*conn, error) {
if dial == nil { if dial == nil {
return setupInboundConn(fd, prv, our, atcap, trust) return setupInboundConn(fd, prv, our, atcap)
} else { } else {
return setupOutboundConn(fd, prv, our, dial, atcap, trust) return setupOutboundConn(fd, prv, our, dial, atcap)
} }
} }
func setupInboundConn(fd net.Conn, prv *ecdsa.PrivateKey, our *protoHandshake, atcap bool, trust map[discover.NodeID]bool) (*conn, error) { func setupInboundConn(fd net.Conn, prv *ecdsa.PrivateKey, our *protoHandshake, atcap bool) (*conn, error) {
secrets, err := receiverEncHandshake(fd, prv, nil) secrets, err := receiverEncHandshake(fd, prv, nil)
if err != nil { if err != nil {
return nil, fmt.Errorf("encryption handshake failed: %v", err) return nil, fmt.Errorf("encryption handshake failed: %v", err)
} }
rw := newRlpxFrameRW(fd, secrets) rw := newRlpxFrameRW(fd, secrets)
if atcap && !trust[secrets.RemoteID] { if atcap {
SendItems(rw, discMsg, DiscTooManyPeers) SendItems(rw, discMsg, DiscTooManyPeers)
return nil, errors.New("we have too many peers") return nil, errors.New("we have too many peers")
} }
@ -99,13 +99,13 @@ func setupInboundConn(fd net.Conn, prv *ecdsa.PrivateKey, our *protoHandshake, a
return &conn{rw, rhs}, nil return &conn{rw, rhs}, nil
} }
func setupOutboundConn(fd net.Conn, prv *ecdsa.PrivateKey, our *protoHandshake, dial *discover.Node, atcap bool, trust map[discover.NodeID]bool) (*conn, error) { func setupOutboundConn(fd net.Conn, prv *ecdsa.PrivateKey, our *protoHandshake, dial *discover.Node, atcap bool) (*conn, error) {
secrets, err := initiatorEncHandshake(fd, prv, dial.ID, nil) secrets, err := initiatorEncHandshake(fd, prv, dial.ID, nil)
if err != nil { if err != nil {
return nil, fmt.Errorf("encryption handshake failed: %v", err) return nil, fmt.Errorf("encryption handshake failed: %v", err)
} }
rw := newRlpxFrameRW(fd, secrets) rw := newRlpxFrameRW(fd, secrets)
if atcap && !trust[secrets.RemoteID] { if atcap {
SendItems(rw, discMsg, DiscTooManyPeers) SendItems(rw, discMsg, DiscTooManyPeers)
return nil, errors.New("we have too many peers") return nil, errors.New("we have too many peers")
} }

4
p2p/handshake_test.go
View File

@ -143,7 +143,7 @@ func TestSetupConn(t *testing.T) {
done := make(chan struct{}) done := make(chan struct{})
go func() { go func() {
defer close(done) defer close(done)
conn0, err := setupConn(fd0, prv0, hs0, node1, false, nil) conn0, err := setupConn(fd0, prv0, hs0, node1, false)
if err != nil { if err != nil {
t.Errorf("outbound side error: %v", err) t.Errorf("outbound side error: %v", err)
return return
@ -156,7 +156,7 @@ func TestSetupConn(t *testing.T) {
} }
}() }()
conn1, err := setupConn(fd1, prv1, hs1, nil, false, nil) conn1, err := setupConn(fd1, prv1, hs1, nil, false)
if err != nil { if err != nil {
t.Fatalf("inbound side error: %v", err) t.Fatalf("inbound side error: %v", err)
} }

58
p2p/server.go
View File

@ -60,9 +60,9 @@ type Server struct {
// with the rest of the network. // with the rest of the network.
BootstrapNodes []*discover.Node BootstrapNodes []*discover.Node
// Trusted nodes are used as privileged connections which are always accepted // Static nodes are used as pre-configured connections which are always
// and also always maintained. // maintained and re-connected on disconnects.
TrustedNodes []*discover.Node StaticNodes []*discover.Node
// NodeDatabase is the path to the database containing the previously seen // NodeDatabase is the path to the database containing the previously seen
// live nodes in the network. // live nodes in the network.
@ -103,8 +103,8 @@ type Server struct {
lock sync.RWMutex // protects running, peers and the trust fields lock sync.RWMutex // protects running, peers and the trust fields
running bool running bool
peers map[discover.NodeID]*Peer peers map[discover.NodeID]*Peer
trusts map[discover.NodeID]*discover.Node // Map of currently trusted remote nodes statics map[discover.NodeID]*discover.Node // Map of currently static remote nodes
trustDial chan *discover.Node // Dial request channel reserved for the trusted nodes staticDial chan *discover.Node // Dial request channel reserved for the static nodes
ntab *discover.Table ntab *discover.Table
listener net.Listener listener net.Listener
@ -114,7 +114,7 @@ type Server struct {
peerWG sync.WaitGroup // active peer goroutines peerWG sync.WaitGroup // active peer goroutines
} }
type setupFunc func(net.Conn, *ecdsa.PrivateKey, *protoHandshake, *discover.Node, bool, map[discover.NodeID]bool) (*conn, error) type setupFunc func(net.Conn, *ecdsa.PrivateKey, *protoHandshake, *discover.Node, bool) (*conn, error)
type newPeerHook func(*Peer) type newPeerHook func(*Peer)
// Peers returns all connected peers. // Peers returns all connected peers.
@ -144,7 +144,7 @@ func (srv *Server) AddPeer(node *discover.Node) {
srv.lock.Lock() srv.lock.Lock()
defer srv.lock.Unlock() defer srv.lock.Unlock()
srv.trusts[node.ID] = node srv.statics[node.ID] = node
} }
// Broadcast sends an RLP-encoded message to all connected peers. // Broadcast sends an RLP-encoded message to all connected peers.
@ -207,11 +207,11 @@ func (srv *Server) Start() (err error) {
srv.peers = make(map[discover.NodeID]*Peer) srv.peers = make(map[discover.NodeID]*Peer)
// Create the current trust map, and the associated dialing channel // Create the current trust map, and the associated dialing channel
srv.trusts = make(map[discover.NodeID]*discover.Node) srv.statics = make(map[discover.NodeID]*discover.Node)
for _, node := range srv.TrustedNodes { for _, node := range srv.StaticNodes {
srv.trusts[node.ID] = node srv.statics[node.ID] = node
} }
srv.trustDial = make(chan *discover.Node) srv.staticDial = make(chan *discover.Node)
if srv.setupFunc == nil { if srv.setupFunc == nil {
srv.setupFunc = setupConn srv.setupFunc = setupConn
@ -246,8 +246,8 @@ func (srv *Server) Start() (err error) {
if srv.NoDial && srv.ListenAddr == "" { if srv.NoDial && srv.ListenAddr == "" {
glog.V(logger.Warn).Infoln("I will be kind-of useless, neither dialing nor listening.") glog.V(logger.Warn).Infoln("I will be kind-of useless, neither dialing nor listening.")
} }
// maintain the trusted peers // maintain the static peers
go srv.trustedNodesLoop() go srv.staticNodesLoop()
srv.running = true srv.running = true
return nil return nil
@ -342,9 +342,9 @@ func (srv *Server) listenLoop() {
} }
} }
// trustedNodesLoop is responsible for periodically checking that trusted // staticNodesLoop is responsible for periodically checking that static
// connections are actually live, and requests dialing if not. // connections are actually live, and requests dialing if not.
func (srv *Server) trustedNodesLoop() { func (srv *Server) staticNodesLoop() {
tick := time.Tick(trustedPeerCheckInterval) tick := time.Tick(trustedPeerCheckInterval)
for { for {
select { select {
@ -352,10 +352,10 @@ func (srv *Server) trustedNodesLoop() {
return return
case <-tick: case <-tick:
// Collect all the non-connected trusted nodes // Collect all the non-connected static nodes
needed := []*discover.Node{} needed := []*discover.Node{}
srv.lock.RLock() srv.lock.RLock()
for id, node := range srv.trusts { for id, node := range srv.statics {
if _, ok := srv.peers[id]; !ok { if _, ok := srv.peers[id]; !ok {
needed = append(needed, node) needed = append(needed, node)
} }
@ -364,9 +364,9 @@ func (srv *Server) trustedNodesLoop() {
// Try to dial each of them (don't hang if server terminates) // Try to dial each of them (don't hang if server terminates)
for _, node := range needed { for _, node := range needed {
glog.V(logger.Debug).Infof("Dialing trusted peer %v", node) glog.V(logger.Debug).Infof("Dialing static peer %v", node)
select { select {
case srv.trustDial <- node: case srv.staticDial <- node:
case <-srv.quit: case <-srv.quit:
return return
} }
@ -425,7 +425,7 @@ func (srv *Server) dialLoop() {
// below MaxPeers. // below MaxPeers.
refresh.Reset(refreshPeersInterval) refresh.Reset(refreshPeersInterval)
} }
case dest := <-srv.trustDial: case dest := <-srv.staticDial:
dial(dest) dial(dest)
case dests := <-findresults: case dests := <-findresults:
for _, dest := range dests { for _, dest := range dests {
@ -469,17 +469,17 @@ func (srv *Server) startPeer(fd net.Conn, dest *discover.Node) {
// the callers of startPeer added the peer to the wait group already. // the callers of startPeer added the peer to the wait group already.
fd.SetDeadline(time.Now().Add(handshakeTimeout)) fd.SetDeadline(time.Now().Add(handshakeTimeout))
// Check capacity and trust list // Check capacity, but override for static nodes
srv.lock.RLock() srv.lock.RLock()
atcap := len(srv.peers) == srv.MaxPeers atcap := len(srv.peers) == srv.MaxPeers
if dest != nil {
trust := make(map[discover.NodeID]bool) if _, ok := srv.statics[dest.ID]; ok {
for id, _ := range srv.trusts { atcap = false
trust[id] = true }
} }
srv.lock.RUnlock() srv.lock.RUnlock()
conn, err := srv.setupFunc(fd, srv.PrivateKey, srv.ourHandshake, dest, atcap, trust) conn, err := srv.setupFunc(fd, srv.PrivateKey, srv.ourHandshake, dest, atcap)
if err != nil { if err != nil {
fd.Close() fd.Close()
glog.V(logger.Debug).Infof("Handshake with %v failed: %v", fd.RemoteAddr(), err) glog.V(logger.Debug).Infof("Handshake with %v failed: %v", fd.RemoteAddr(), err)
@ -535,14 +535,14 @@ func (srv *Server) addPeer(id discover.NodeID, p *Peer) (bool, DiscReason) {
// checkPeer verifies whether a peer looks promising and should be allowed/kept // checkPeer verifies whether a peer looks promising and should be allowed/kept
// in the pool, or if it's of no use. // in the pool, or if it's of no use.
func (srv *Server) checkPeer(id discover.NodeID) (bool, DiscReason) { func (srv *Server) checkPeer(id discover.NodeID) (bool, DiscReason) {
// First up, figure out if the peer is trusted // First up, figure out if the peer is static
_, trusted := srv.trusts[id] _, static := srv.statics[id]
// Make sure the peer passes all required checks // Make sure the peer passes all required checks
switch { switch {
case !srv.running: case !srv.running:
return false, DiscQuitting return false, DiscQuitting
case !trusted && len(srv.peers) >= srv.MaxPeers: case !static && len(srv.peers) >= srv.MaxPeers:
return false, DiscTooManyPeers return false, DiscTooManyPeers
case srv.peers[id] != nil: case srv.peers[id] != nil:
return false, DiscAlreadyConnected return false, DiscAlreadyConnected

12
p2p/server_test.go
View File

@ -22,7 +22,7 @@ func startTestServer(t *testing.T, pf newPeerHook) *Server {
ListenAddr: "127.0.0.1:0", ListenAddr: "127.0.0.1:0",
PrivateKey: newkey(), PrivateKey: newkey(),
newPeerHook: pf, newPeerHook: pf,
setupFunc: func(fd net.Conn, prv *ecdsa.PrivateKey, our *protoHandshake, dial *discover.Node, atcap bool, trust map[discover.NodeID]bool) (*conn, error) { setupFunc: func(fd net.Conn, prv *ecdsa.PrivateKey, our *protoHandshake, dial *discover.Node, atcap bool) (*conn, error) {
id := randomID() id := randomID()
rw := newRlpxFrameRW(fd, secrets{ rw := newRlpxFrameRW(fd, secrets{
MAC: zero16, MAC: zero16,
@ -102,7 +102,7 @@ func TestServerDial(t *testing.T) {
// tell the server to connect // tell the server to connect
tcpAddr := listener.Addr().(*net.TCPAddr) tcpAddr := listener.Addr().(*net.TCPAddr)
srv.trustDial <- &discover.Node{IP: tcpAddr.IP, TCPPort: tcpAddr.Port} srv.staticDial <- &discover.Node{IP: tcpAddr.IP, TCPPort: tcpAddr.Port}
select { select {
case conn := <-accepted: case conn := <-accepted:
@ -200,7 +200,7 @@ func TestServerDisconnectAtCap(t *testing.T) {
// Run the handshakes just like a real peer would. // Run the handshakes just like a real peer would.
key := newkey() key := newkey()
hs := &protoHandshake{Version: baseProtocolVersion, ID: discover.PubkeyID(&key.PublicKey)} hs := &protoHandshake{Version: baseProtocolVersion, ID: discover.PubkeyID(&key.PublicKey)}
_, err = setupConn(conn, key, hs, srv.Self(), false, nil) _, err = setupConn(conn, key, hs, srv.Self(), false)
if i == nconns-1 { if i == nconns-1 {
// When handling the last connection, the server should // When handling the last connection, the server should
// disconnect immediately instead of running the protocol // disconnect immediately instead of running the protocol
@ -219,6 +219,7 @@ func TestServerDisconnectAtCap(t *testing.T) {
} }
} }
/*
// Tests that trusted peers and can connect above max peer caps. // Tests that trusted peers and can connect above max peer caps.
func TestServerTrustedPeers(t *testing.T) { func TestServerTrustedPeers(t *testing.T) {
defer testlog(t).detach() defer testlog(t).detach()
@ -250,7 +251,7 @@ func TestServerTrustedPeers(t *testing.T) {
// Run the handshakes just like a real peer would, and wait for completion // Run the handshakes just like a real peer would, and wait for completion
key := newkey() key := newkey()
shake := &protoHandshake{Version: baseProtocolVersion, ID: discover.PubkeyID(&key.PublicKey)} shake := &protoHandshake{Version: baseProtocolVersion, ID: discover.PubkeyID(&key.PublicKey)}
if _, err = setupConn(conn, key, shake, server.Self(), false, nil); err != nil { if _, err = setupConn(conn, key, shake, server.Self(), false); err != nil {
t.Fatalf("conn %d: unexpected error: %v", i, err) t.Fatalf("conn %d: unexpected error: %v", i, err)
} }
<-started <-started
@ -269,7 +270,7 @@ func TestServerTrustedPeers(t *testing.T) {
defer conn.Close() defer conn.Close()
shake := &protoHandshake{Version: baseProtocolVersion, ID: trusted.ID} shake := &protoHandshake{Version: baseProtocolVersion, ID: trusted.ID}
if _, err = setupConn(conn, key, shake, server.Self(), false, nil); err != nil { if _, err = setupConn(conn, key, shake, server.Self(), false); err != nil {
t.Fatalf("trusted node: unexpected error: %v", err) t.Fatalf("trusted node: unexpected error: %v", err)
} }
select { select {
@ -280,6 +281,7 @@ func TestServerTrustedPeers(t *testing.T) {
t.Fatalf("trusted node timeout") t.Fatalf("trusted node timeout")
} }
} }
*/
func newkey() *ecdsa.PrivateKey { func newkey() *ecdsa.PrivateKey {
key, err := crypto.GenerateKey() key, err := crypto.GenerateKey()