mirror of
https://github.com/status-im/nimbus-eth2.git
synced 2025-01-24 05:22:03 +00:00
a7a65bce42
* reorganize ssz dependencies This PR continues the work in https://github.com/status-im/nimbus-eth2/pull/2646, https://github.com/status-im/nimbus-eth2/pull/2779 as well as past issues with serialization and type, to disentangle SSZ from eth2 and at the same time simplify imports and exports with a structured approach. The principal idea here is that when a library wants to introduce SSZ support, they do so via 3 files: * `ssz_codecs` which imports and reexports `codecs` - this covers the basic byte conversions and ensures no overloads get lost * `xxx_merkleization` imports and exports `merkleization` to specialize and get access to `hash_tree_root` and friends * `xxx_ssz_serialization` imports and exports `ssz_serialization` to specialize ssz for a specific library Those that need to interact with SSZ always import the `xxx_` versions of the modules and never `ssz` itself so as to keep imports simple and safe. This is similar to how the REST / JSON-RPC serializers are structured in that someone wanting to serialize spec types to REST-JSON will import `eth2_rest_serialization` and nothing else. * split up ssz into a core library that is independendent of eth2 types * rename `bytes_reader` to `codec` to highlight that it contains coding and decoding of bytes and native ssz types * remove tricky List init overload that causes compile issues * get rid of top-level ssz import * reenable merkleization tests * move some "standard" json serializers to spec * remove `ValidatorIndex` serialization for now * remove test_ssz_merkleization * add tests for over/underlong byte sequences * fix broken seq[byte] test - seq[byte] is not an SSZ type There are a few things this PR doesn't solve: * like #2646 this PR is weak on how to handle root and other dontSerialize fields that "sometimes" should be computed - the same problem appears in REST / JSON-RPC etc * Fix a build problem on macOS * Another way to fix the macOS builds Co-authored-by: Zahary Karadjov <zahary@gmail.com>
69 lines
2.4 KiB
Nim
69 lines
2.4 KiB
Nim
# beacon_chain
|
|
# Copyright (c) 2018-Present Status Research & Development GmbH
|
|
# Licensed and distributed under either of
|
|
# * MIT license (license terms in the root directory or at https://opensource.org/licenses/MIT).
|
|
# * Apache v2 license (license terms in the root directory or at https://www.apache.org/licenses/LICENSE-2.0).
|
|
# at your option. This file may not be copied, modified, or distributed except according to those terms.
|
|
|
|
{.used.}
|
|
|
|
import
|
|
# Standard library
|
|
os,
|
|
# Utilities
|
|
unittest2,
|
|
stew/results,
|
|
# Beacon chain internals
|
|
../../../beacon_chain/spec/beaconstate,
|
|
../../../beacon_chain/spec/datatypes/phase0,
|
|
# Test utilities
|
|
../../testutil,
|
|
../fixtures_utils,
|
|
../../helpers/debug_state
|
|
|
|
const OperationsAttestationsDir = SszTestsDir/const_preset/"phase0"/"operations"/"attestation"/"pyspec_tests"
|
|
|
|
proc runTest(identifier: string) =
|
|
# We wrap the tests in a proc to avoid running out of globals
|
|
# in the future: Nim supports up to 3500 globals
|
|
# but unittest with the macro/templates put everything as globals
|
|
# https://github.com/nim-lang/Nim/issues/12084#issue-486866402
|
|
|
|
let testDir = OperationsAttestationsDir / identifier
|
|
|
|
proc `testImpl _ operations_attestations _ identifier`() =
|
|
|
|
var prefix: string
|
|
if existsFile(testDir/"post.ssz_snappy"):
|
|
prefix = "[Valid] "
|
|
else:
|
|
prefix = "[Invalid] "
|
|
|
|
test prefix & identifier:
|
|
var cache = StateCache()
|
|
|
|
let attestation =
|
|
parseTest(testDir/"attestation.ssz_snappy", SSZ, Attestation)
|
|
var preState =
|
|
newClone(parseTest(testDir/"pre.ssz_snappy", SSZ, phase0.BeaconState))
|
|
|
|
if existsFile(testDir/"post.ssz_snappy"):
|
|
let postState =
|
|
newClone(parseTest(testDir/"post.ssz_snappy", SSZ, phase0.BeaconState))
|
|
let done = process_attestation(
|
|
preState[], attestation, {}, 0.Gwei, cache).isOk
|
|
doAssert done, "Valid attestation not processed"
|
|
check: preState[].hash_tree_root() == postState[].hash_tree_root()
|
|
reportDiff(preState, postState)
|
|
else:
|
|
let done = process_attestation(
|
|
preState[], attestation, {}, 0.Gwei, cache).isOk
|
|
doAssert done == false, "We didn't expect this invalid attestation to be processed."
|
|
|
|
`testImpl _ operations_attestations _ identifier`()
|
|
|
|
suite "Official - Phase 0 - Operations - Attestations " & preset():
|
|
for kind, path in walkDir(
|
|
OperationsAttestationsDir, relative = true, checkDir = true):
|
|
runTest(path)
|