mirror of
https://github.com/status-im/nimbus-eth2.git
synced 2025-02-03 02:05:03 +00:00
8b01284b0e
hash_tree_root was turning up when running beacon_node, turns out to be repeated hash_tree_root invocations - this pr brings them back down to normal. this PR caches the root of a block in the SignedBeaconBlock object - this has the potential downside that even invalid blocks will be hashed (as part of deserialization) - later, one could imagine delaying this until checks have passed there's also some cleanup of the `cat=` logs which were applied randomly and haphazardly, and to a large degree are duplicated by other information in the log statements - in particular, topics fulfill the same role
53 lines
1.7 KiB
Nim
53 lines
1.7 KiB
Nim
# beacon_chain
|
|
# Copyright (c) 2018-2020 Status Research & Development GmbH
|
|
# Licensed and distributed under either of
|
|
# * MIT license (license terms in the root directory or at https://opensource.org/licenses/MIT).
|
|
# * Apache v2 license (license terms in the root directory or at https://www.apache.org/licenses/LICENSE-2.0).
|
|
# at your option. This file may not be copied, modified, or distributed except according to those terms.
|
|
|
|
import
|
|
chronicles, tables, options,
|
|
stew/bitops2,
|
|
metrics,
|
|
../spec/[datatypes, digest],
|
|
block_pools_types
|
|
|
|
export options
|
|
|
|
logScope:
|
|
topics = "quarant"
|
|
|
|
{.push raises: [Defect].}
|
|
|
|
func checkMissing*(quarantine: var Quarantine): seq[FetchRecord] =
|
|
## Return a list of blocks that we should try to resolve from other client -
|
|
## to be called periodically but not too often (once per slot?)
|
|
var done: seq[Eth2Digest]
|
|
|
|
for k, v in quarantine.missing.mpairs():
|
|
if v.tries > 8:
|
|
done.add(k)
|
|
else:
|
|
inc v.tries
|
|
|
|
for k in done:
|
|
# TODO Need to potentially remove from quarantine.pending - this is currently a
|
|
# memory leak here!
|
|
quarantine.missing.del(k)
|
|
|
|
# simple (simplistic?) exponential backoff for retries..
|
|
for k, v in quarantine.missing.pairs():
|
|
if countOnes(v.tries.uint64) == 1:
|
|
result.add(FetchRecord(root: k))
|
|
|
|
func addMissing*(quarantine: var Quarantine, broot: Eth2Digest) {.inline.} =
|
|
discard quarantine.missing.hasKeyOrPut(broot, MissingBlock())
|
|
|
|
func add*(quarantine: var Quarantine, dag: CandidateChains,
|
|
sblck: SignedBeaconBlock) =
|
|
## Adds block to quarantine's `orphans` and `missing` lists.
|
|
quarantine.orphans[sblck.root] = sblck
|
|
|
|
let parentRoot = sblck.message.parent_root
|
|
quarantine.addMissing(parentRoot)
|