f4c215c5e6
cleanup `state_transition_epoch` and bump to v1.3.0 ( #4922 )
...
* cleanup `state_transition_epoch` and bump to v1.3.0
More v1.3.0 consensus-specs bumps, focused on `state_transition_epoch`.
Also fixed `current_epoch` spurious style check warning, and cleanup.
* Update beacon_chain/spec/state_transition_epoch.nim
2023-05-10 04:31:23 +02:00
34a81f56c3
bump web3 ( #4919 )
...
and update fakeee
2023-05-09 22:51:57 +00:00
34e7181b0d
`KZG(Commitment(s)?|Proof)` > `Kzg$1` ( #4917 )
...
Fix style-check by using matching capitalization for `nim-kzg` types.
2023-05-09 19:51:36 +00:00
93899b2e2a
consensus-specs v1.3.0 bumps with cleanup ( #4918 )
...
Some more consensus-specs v1.3.0 bumps. No semantic logic changes,
but also contains cleanup, so separate PR to reduce noise.
2023-05-09 20:16:49 +02:00
e9319a5947
`bls_to_execution_changes` check alternative ( #4916 )
...
Make intent clearer about when to expect `bls_to_execution_changes`,
and replace test-time errors with compile-time errors if the field
is renamed or goes away in the future.
2023-05-09 17:24:02 +00:00
b04970189b
more v1.3.0 consensus-specs bumps ( #4915 )
...
More spec references for unchanged logic bumped to v1.3.0.
2023-05-09 17:20:37 +00:00
5c5fbc088f
simplify FC weight computation ( #4892 )
...
Optimizations from https://github.com/ethereum/consensus-specs/pull/3246
avoid a couple unnecessary divisions when calculating proposer boost.
2023-05-09 10:16:13 +00:00
5b3c211285
`checkedReject` > `errReject` for CI failure ( #4909 )
...
The `SignedContributionAndProof: invalid contribution signature` check
is sometimes hit around fork boundaries when running local testnet.
To avoid failing CI, revert this isntance to a plain `errReject` until
the underlying problem is addressed.
2023-05-09 09:44:24 +00:00
6458133f5c
disable conditionality of warning disabling ( #4908 )
...
* disable conditionality of warning disabling
* add copyright notice with current year
* express version constraint in nimble file
* also needs copyright year
2023-05-09 09:30:29 +00:00
40253a76dd
Version 23.5.0 ( #4913 )
2023-05-09 11:17:18 +03:00
5bf9284e62
Initial public version of the Verifying Web3Signer functionality ( #4912 )
...
* Allow the list of proved properties for web3signer to be configured
* Document the Web3Signer setups (regular, distributed and verified)
2023-05-09 11:16:43 +03:00
3a1c468991
use merge-base for copyright year check ( #4907 )
...
Instead of comparing against current base branch head, use the common
ancestor of the PR and the base branch to avoid false positives when
a year was bumped in the base branch but not yet merged into the PR.
2023-05-09 04:07:47 +02:00
8f9bb391a3
don't consider attempt to route duplicate block an error ( #4904 )
2023-05-08 14:59:13 +02:00
53436c2b9b
Add blob validation condition ( #4902 )
2023-05-06 20:09:17 +00:00
a23252c297
reorder `get_initial_beacon_block` by fork ( #4899 )
...
Deneb was listed between Capella and Bellatrix. Swap with Capella.
2023-05-06 10:32:59 +00:00
23adf15e5a
Blob handling sync fixes ( #4888 )
...
* Fix groupBlobs
* Fix getShortMap
* Fix blob handling in sync
* lint
* Add some blob-related logging
2023-05-06 08:58:50 +00:00
ae46be7020
Sign the blinded blocks only if they provide better value than the EL block ( #4894 )
2023-05-06 10:32:30 +02:00
1ebcd8b473
`excess_data_gas` after `withdrawals` cleanup ( #4900 )
...
We already updated the field order in the actual `ExecutionPayload`,
but in init code and tests / logs etc we still used the old order.
Update those occurrences to also match the field order in the struct.
Furthermore, add `excess_data_gas` to last entry in `test_eth1_monitor`.
2023-05-05 23:15:47 +00:00
297881edb7
bump gossip validation refs to 1.3.0 spec ( #4895 )
...
Updates gossip validation spec references to v1.3.0 and fixes an
incorrect reference to "signed_aggregate_and_proof" in sync contribution
documentation.
2023-05-05 22:48:33 +02:00
508819633a
more consensus-specs v1.3.0 bumps ( #4898 )
...
Updates more consensus-specs references to v1.3.0.
This PR only includes updates for sections otherwise unmodified.
2023-05-05 20:38:51 +00:00
e408c7573d
bump more consensus-specs refs to v1.3.0 (with comments) ( #4901 )
...
Bump some more consensus-specs links to v1.3.0, and also align comments
with latest specs where they differ, and fix typos.
2023-05-05 20:37:56 +00:00
28968c11ba
remove `SAFE_SLOTS_TO_UPDATE_JUSTIFIED` ( #4897 )
...
The `SAFE_SLOTS_TO_UPDATE_JUSTIFIED` constant is no longer used as the
bouncing attack fix was removed:
https://github.com/ethereum/consensus-specs/pull/3290
Note: Some test networks still define the constant, ignoring the config
constant for now until it is no longer used.
2023-05-05 18:11:38 +00:00
0ad9ab446d
cleanup FC spec refs and align closer ( #4893 )
...
Bump FC spec references to v1.3.0, and visually align closer with
specs where trivial to do so without structural changes.
2023-05-05 17:03:54 +00:00
d784672c10
Always use fresh HTTP connections for EL communication
2023-05-05 02:27:26 +03:00
2bd9e5a54c
log/read error from correct failed future ( #4890 )
2023-05-04 19:53:25 +03:00
1e7eec18ce
Bugfix: Invalid execution header HTR leads to invalid state root ( #4889 )
2023-05-04 19:52:43 +03:00
4a1b94bc2e
update Deneb ANSI art for readability 🐟 ( #4885 )
...
Make "L" characters wider to improve readability.
Thanks to http://beatscribe.com (beatscribe#1008 on Discord)
2023-05-03 22:25:01 +02:00
b5b51de67c
align `BeaconState` docs with latest spec ( #4884 )
...
Only comment changes:
- Bump refs to final v1.3.0 spec
- Align documentation style in various `BeaconState` structures
- Add `justification_bits` / `historical_roots` comment from spec
- Remove `previous_justified_checkpoint` from non-phase0 (same as spec)
- Cleanup some `Modified` tags
2023-05-03 13:05:46 +02:00
18d1f62ff1
Add logging for EL request time outs
2023-05-02 16:52:26 +03:00
0c75f9c2df
VC: Fix issue when optimistically synced node could block sync committee service functions. ( #4878 )
...
* Fix issue when optimistically synced node could block sync committee service functions.
* Update copyright year.
2023-05-02 14:54:44 +03:00
ecaf6c8e92
harden gossip `strictVerification` in local testnets ( #4880 )
...
Fail local testnets on any gossip REJECT, instead of just asserting some
of the attestation related checks. This now also ensures that blocks,
BLS to Execution changes, blob sidecars and LC messages are checked
when running in a local testnet environment (`--verify-finalization`).
https://github.com/status-im/nimbus-eth2/pull/2904#discussion_r719603935
2023-05-02 13:06:02 +02:00
dc32add555
only trigger liveness failsafe for mainnet ( #4882 )
...
* only trigger liveness failsafe for mainnet
* more user-friendly log
2023-05-01 11:45:39 +02:00
bb62fee7d5
fix gossip validation for duplicate blob sidecars ( #4881 )
...
`SignedBlobSidecar: already have blob with valid signature` is IGNORE
in spec, but was implemented as REJECT. Align with spec.
2023-05-01 08:08:39 +02:00
55592db3b1
secp256k1 0.3.1 ( #4843 )
...
Celebrating their new release policy!
2023-04-30 08:51:48 +00:00
ee1bda63fa
fix copyright year check if only submodules bumped ( #4879 )
...
When only submodules were bumped but no other changes are committed,
`git diff` returns empty list, and `grep` returns 1. Suppress `grep`
error to prevent CI fail in that case.
2023-04-29 18:39:39 +00:00
5ccb085b9b
block_quarantine.nim: remove unused import ( #4877 )
...
leftover from #4844
2023-04-28 22:41:55 +00:00
a32054cdd1
BlobQuarantine.hasBlobs: fix for loop bound ( #4876 )
2023-04-28 19:27:28 +00:00
cf202fb928
Update nim-web3 ( #4875 )
...
Update to new version of nim-web3 incorporating the execution API
change that merges getPayloadV3 and getBlobsBundleV1.
2023-04-28 19:20:25 +00:00
8ef6223026
ignore submodules in copyright check ( #4874 )
...
Otherwise, they get reported as missing copyright header whenever
selecting a new commit for a submodule.
2023-04-28 16:57:51 +02:00
ef0b95dfbc
RequestManager: add support for fetching Blobs ( #4844 )
...
* RequestManager: add support for fetching Blobs
* Review feedback
* Lint
* Change peekSortedBlobless -> peekBlobless
2023-04-28 12:57:35 +00:00
1027b98ea0
Merge branch 'stable' into unstable
2023-04-28 11:00:15 +03:00
c558dca726
Remove the 386 build from the Nightly release as it's no longer available
2023-04-28 10:59:46 +03:00
2ae909d9b9
Documentation improvements ( #4794 )
2023-04-28 00:30:58 +03:00
0d6453aa51
Add an USE_VC env variable affecting the local simulation targets
2023-04-28 00:21:01 +03:00
3b58711e6b
Merge branch 'stable' into unstable
2023-04-28 00:12:37 +03:00
40eb7477ae
only run copyright year check in pull requests ( #4871 )
...
On `unstable`, the `git diff` doesn't work, so only check during PR.
2023-04-27 16:46:09 +00:00
e5a5731be6
Fix the cross-compilation for macOS and re-enable its packaging
2023-04-27 19:29:52 +03:00
351f043a61
check current copyright year in modified files ( #4868 )
...
On PR, ensure current year is listed in copyright of modified files.
Runs on Linux GitHub.
2023-04-27 17:55:11 +02:00
964417d8ba
cache computed mock pubkeys in tests ( #4869 )
...
We have a few tests that access `MockPubKeys`. Adding a cache provides
a minor speedup, as repeated pubkey computations are avoided.
64 cache hits: EF - Capella - Unittests - Light client - Sync protocol
64 cache hits: EF - Altair - Unittests - Light client - Sync protocol
256 cache hits: EF - Capella - Unittests - Light client - Sync protocol
256 cache hits: EF - Altair - Unittests - Light client - Sync protocol
2297 cache hits: Attestation pool processing [Preset: mainnet]
512 cache hits: Beacon chain DB [Preset: mainnet]
32 cache hits: Block processor [Preset: mainnet]
1082 cache hits: Validator change pool testing suite
192 cache hits: Gossip validation [Preset: mainnet]
32 cache hits: Gossip validation - Extra
192 cache hits: Spec helpers
32 cache hits: Light client processor [Preset: mainnet]
96 cache hits: Light client [Preset: mainnet]
192 cache hits: Beacon state [Preset: mainnet]
37 cache hits: state diff tests [Preset: mainnet]
160 cache hits: Block pool processing [Preset: mainnet]
32 cache hits: Block pool altair processing [Preset: mainnet]
96 cache hits: chain DAG finalization tests [Preset: mainnet]
32 cache hits: Old database versions [Preset: mainnet]
64 cache hits: Diverging hardforks
96 cache hits: Backfill
32 cache hits: Starting states
32 cache hits: Latest valid hash [Preset: mainnet]
32 cache hits: Pruning
5912 cache hits total per `make -j test`.
2023-04-27 15:04:56 +00:00
e6a6019ef9
Fix the cross-compilation for Windows
2023-04-27 16:28:10 +03:00
Etan Kissling
Jacek Sieka
tersec
zah
henridf
Eugene Kabanov