andri lim
0b276315d2
Bump nim-eth: Convert GasInt to uint64 ( #6415 )
...
* Bump nim-eth: Convert GasInt to uint64
* Fixes
* Fix libnimbus_lc
2024-07-06 20:25:31 +00:00
Etan Kissling
7f59e80aaa
validate EL block hash in Electra when no EL is connected ( #6407 )
...
When no EL is connected, it is still required to validate the block hash
of `ExecutionPayload` to prevent attacks that trick us into attesting to
a circular chain with invalid in-between block hashes. This is already
done through Deneb but was still missing in Electra to be rectified now.
2024-07-05 10:18:50 +02:00
Eugene Kabanov
c59bb71916
Add implementation of publishBlindedBlockV2() REST API endpoint. ( #6413 )
2024-07-04 19:48:12 +00:00
Etan Kissling
abf818a9f3
bump nim-eth to `d8fda55c79dd48ba564f3cb540b968f4a1c1aae6` ( #6405 )
...
* bump nim-eth to `d8fda55c79dd48ba564f3cb540b968f4a1c1aae6`
- Overhaul of ENR implementation - part I
- Rework of ENR decoding code
- Update discv5 to use non deprecated ENR calls and simplify code
- simplify .nimble file
- avoid warnings when processing `GasInt` for RLP
- define Electra types and RLP encoding
* explicitly indicate consensus types over nim-eth types in EL manager
2024-07-04 18:40:11 +00:00
tersec
9f654690b8
update builder API registrations after keymanager API fee recipient change ( #6412 )
2024-07-04 14:08:07 +02:00
Eugene Kabanov
85c2850971
Fix publishBlockV1() and publishBlockV2() SSZ decoding process. ( #6408 )
2024-07-04 01:08:07 +00:00
Eugene Kabanov
84a35c85c5
Fix for gcc-14 issues in kzg-4844. ( #6403 )
...
* Bump nim-kzg4844.
* Fix code to use proper KZG types.
* Add missing coma.
* Fix compilation issue.
* Bump nim-kzg4844.
* Add debugging output.
* Remove debugging output.
* Restore groupBlobs function.
2024-07-03 10:01:33 +00:00
Etan Kissling
515bd486e6
ensure passing unsigned integer to `rlp.encode` ( #6397 )
...
RLP encoding is not defined for signed integers. Make sure to use
unsigned integers when encoding RLP for EL block hash computation.
2024-07-03 01:43:16 +00:00
Etan Kissling
fba8cc3ee5
fix EIP reference in Electra type definition ( #6398 )
...
The field `withdrawal_requests` is from EIP-7002 instead of EIP-6110.
2024-07-03 01:41:01 +00:00
tersec
8c67a265d0
bump nim-web3 to align WithdrawalRequestV1 with EIP-7002 and consensus spec ( #6395 )
2024-07-01 16:07:30 +02:00
tersec
13e766d4df
add database electra block tests ( #6394 )
2024-07-01 04:18:41 +00:00
Eugene Kabanov
190dbfd481
Fix empty status string handling, address #6175 . ( #6391 )
2024-06-28 05:54:51 +02:00
Etan Kissling
9924aec1e3
extend light client protocol for Electra ( #6375 )
...
* extend light client protocol for Electra
Add missing Electra support for light client protocol:
- https://github.com/ethereum/consensus-specs/pull/3811
Tested against PR consensus-spec-tests, the test runner automatically
picks up the new tests once available.
* workaround `version-2-0`: `Error: cannot instantiate: 'SomeUnsignedInt'`
* fix initialization when Electra not scheduled
* try reduce stack size in test
* put correct sync committee branch version into DB
* adjust fork schedule in light client data tests
* further reduce stack size
* split function into multiple parts
* rename variable
* regenerate test reports to cover new Electra tests
* add Nim bug reference
2024-06-26 19:02:03 +00:00
Etan Kissling
3da85e593f
update references for LC related Nim issues ( #6389 )
...
Addresses feedback from #6375 that is applicable to pre-existing code
moreso than to the new PR.
2024-06-26 14:31:36 +02:00
tersec
288540e794
fix UnnamedBreak deprecation build warnings ( #6388 )
2024-06-26 10:48:49 +02:00
tersec
a787c85589
Merge remote-tracking branch 'origin/stable' into unstable
2024-06-24 09:23:31 +00:00
Etan Kissling
cd4de1357a
during proposal duties, perform sync aggregation duties if not received ( #6384 )
...
Including sync contributions into a block affects validator rewards.
When we have not received aggregate sync contributions, but have seen
individual messages, we can produce the contributions locally, improving
validator rewards when subscribing to all subnets or when having a
non-aggregating attached validator in the sync committee.
2024-06-24 09:13:15 +00:00
tersec
7d00786d5e
version v24.6.0
2024-06-24 07:25:15 +00:00
Etan Kissling
e4efe9ed75
ensure that rarely ran files are compiled on PR ( #6379 )
...
* ensure that rarely ran files are compiled on PR
Add some missing files to `isMainModule` developer internal builds CI.
* fix fork choice compilation
* fix `rest_api_benchmark` compilation
* skip linking
* fix loop
* fix `mock_genesis`
* fix signedness
2024-06-23 23:35:56 +00:00
tersec
9b6b42c8f9
some consensus spec URL updates to v1.5.0-alpha.3 ( #6382 )
2024-06-22 07:28:19 +02:00
tersec
b759038ba8
increase TNS state download timeout to 90 ( #6363 )
2024-06-21 22:14:28 +00:00
Etan Kissling
8bc53bde71
bump holesky to `874c199423ccd180607320c38cbaca05d9a1573a` ( #6377 )
...
- Add Chainlens explorer for Holesky
- update repository layout
2024-06-21 21:51:25 +00:00
Etan Kissling
31653d5869
fix DB size estimates for light client data ( #6373 )
...
Addresses two inaccuracies in light client data size documentation:
1. `SyncCommittee` pubkeys serialize are 48 bytes not 64 bytes
2. Some of the estimates used 1000 vs 1024 bytes/KB, aligned to 1024
2024-06-21 12:39:38 +00:00
Etan Kissling
22b5bc6256
cleanup Electra fork references ( #6372 )
...
Adjust two fork references to match surrounding code style.
2024-06-20 21:09:41 +02:00
Eugene Kabanov
61610fd243
BN: Disable genesis sync via long-range-sync argument. ( #6361 )
...
* Initial commit.
* Update options.md.
* Add pre-database initialization weak subjectivity period check.
* Add proper log message.
2024-06-20 18:57:08 +00:00
Kim De Mey
7a8c1d818a
Bump nim-eth for Opt changes and make Opt related adjustments ( #6369 )
2024-06-18 23:46:51 +02:00
tersec
bfd1a36fcf
add engine API consolidation requests support for getPayloadV4/newPayloadV4 ( #6368 )
2024-06-18 07:35:36 +02:00
tersec
350c4eaa39
rm Goerli remnant; add explanatory comment about opt sync validation ( #6365 )
2024-06-17 09:40:41 +00:00
tersec
88fa8b17ea
automated consensus spec URL updating to v1.5.0-alpha.3 ( #6364 )
2024-06-16 02:59:25 +02:00
tersec
0fab9682a6
use EF consensus-specs v1.5.0-alpha.3 test vectors ( #6362 )
2024-06-16 00:15:27 +02:00
tersec
a93ab7cf3b
Revert "bump nim-kzg4844 for gcc-14 compatibility ( #6342 )" ( #6360 )
...
This reverts commit c5326619a4
.
2024-06-14 23:23:19 +00:00
Etan Kissling
9fc870777c
remove Bellatrix EL syncing support from light client ( #6352 )
...
Bellatrix light client data does not contain the EL block hash, so we
had to follow blocks gossip to learn the EL `block_hash` of such blocks.
Now that Bellatrix is obsolete, we can simplify EL syncing logic under
light client scenarios. Bellatrix light client data can still be used
to advance the light client sync itself, but will no longer result in
`engine_forkchoiceUpdated` calls until the sync reaches Capella. This
also frees up some memory as we no longer have to retain blocks.
2024-06-14 01:23:17 +00:00
Eugene Kabanov
c5326619a4
bump nim-kzg4844 for gcc-14 compatibility ( #6342 )
...
* Bump nim-kzg4844.
* Fix code to use proper KZG types.
* Add missing coma.
* Fix compilation issue.
* Bump nim-kzg4844.
2024-06-14 00:46:03 +00:00
Etan Kissling
b6d6247fa1
fix light client topic subscriptions ( #6351 )
...
Using `let contextFork = consensusFork` no longer seems to work to avoid
capturing the `var` loop variable; it ends up being `Electra` for all
handlers. Use `closureScope` as a more sustainable fix.
2024-06-14 00:45:40 +00:00
andri lim
fb0494e739
Bump nim-eth for revert GasInt back to int64 ( #6347 )
...
* Bump nim-eth for revert GasInt back to int64
* Fix libnimbus_lc
2024-06-13 15:25:59 +02:00
Etan Kissling
20af24efdb
align field name across `SomeSig` ( #6348 )
...
`ValidatorSig` uses `blob` but `TrustedSig` uses `data`, aligning the
names reduces code duplication and improves clarity. It also simplifies
`StableContainer` compatibility checks.
2024-06-13 13:11:04 +00:00
andri lim
238589868c
Bump nim-web3 and nim-eth ( #6345 )
...
In nim-web3 all std.Option are replaced by results.Opt. The same goes in nim-eth, with additional fields name changes and GasInt changed from int64 to uint64.
2024-06-12 08:46:39 +07:00
Eugene Kabanov
27664291c4
VC/NIMBUS-BN validators protection. ( #6329 )
...
* Beacon node side implementation.
* Validator client side implementation.
* Address review comments and fix the test.
* Only 400 errors could be IndexedErrorMessage, 500 errors are always ErrorMessage.
* Remove VC shutdown functionality.
* Remove magic constants.
* Make arguments more visible and disable default values.
* Address review comments.
2024-06-11 19:38:16 +00:00
Kim De Mey
741075aada
Bump nim-eth module and add async raises for eth2 discovery ( #6344 )
2024-06-11 19:50:08 +02:00
tersec
77d926525f
stop using deprecated stew/results ( #6343 )
...
* stop using deprecated stew/results
* exception tracking linting
2024-06-11 02:34:56 +00:00
Etan Kissling
cccd81a47b
add ANSI art placeholder for Electra 🦒 ( #6338 )
...
Trigger ANSI art on upgrade to Electra
Art created by http://beatscribe.com (beatscribe#1008 on Discord)
2024-06-10 16:45:40 +00:00
tersec
598485ee1a
add consolidations block body packing plumbing and correct electra MEV block body htr override ( #6335 )
2024-06-10 05:05:51 +02:00
tersec
e3d4ad5d39
properly (re)factor consolidation signature checking ( #6334 )
2024-06-09 19:37:41 +02:00
Eugene Kabanov
0512d02766
VC enable block monitoring by default. ( #6331 )
2024-06-07 15:04:29 +00:00
Etan Kissling
ab892c1a04
bump `mainnet` to `f6b7882618a5ad2c1d2731ae35e5d16a660d5bb7` ( #6310 )
...
* bump `mainnet` to `f6b7882618a5ad2c1d2731ae35e5d16a660d5bb7`
- Initial commit
* fix soft links
2024-05-30 09:28:16 +00:00
Eugene Kabanov
1cdb32222b
VC: Add block scoring ( #6303 )
...
* Add scoring for blocks.
* Update Alltests.
2024-05-29 10:07:39 +00:00
Etan Kissling
0efc81d96d
use correct minimum size when reading block / state headers ( #6263 )
...
`sizeof` also includes padding between fields, while SSZ defines
`fixedPortionSize` (on type) or `sszSize` (on value) to denote
required bytes to encode. Switch forked block/state readers to SSZ size.
As blocks/states are much larger than the padding, this doesn't affect
practical use cases but is slightly more correct this way.
2024-05-25 07:30:05 +02:00
tersec
c7bf6fb542
rm debugRaiseAssert; clean up several debugComments ( #6308 )
...
* rm debugRaiseAssert; clean up several debugComments
* exception linting
2024-05-23 23:51:09 +02:00
tersec
a7b5741163
Merge remote-tracking branch 'origin/stable' into unstable
2024-05-23 13:29:21 +00:00
tersec
a98c119b98
version v24.5.1
2024-05-23 10:52:55 +00:00
tersec
73f56b5026
version v24.5.0
2024-05-23 03:44:54 +00:00
tersec
b56a671122
fix most ConvFromXtoItselfNotNeeded hints and unhide remaining ones ( #6307 )
2024-05-22 13:56:37 +02:00
tersec
708b23f084
rm unused produceBlockV2Plain() RPC signature ( #6304 )
2024-05-22 07:47:03 +02:00
tersec
3e6990ccc4
rm unused ProduceBlockResponseV2 type ( #6302 )
2024-05-22 04:52:35 +02:00
tersec
dd452f71d3
rm outdated/semi-duplicate execution layer withdrawal request processing ( #6301 )
2024-05-22 01:59:11 +02:00
Eugene Kabanov
34853ca155
VC: Deprecate fallback path to produceBlockV2, use produceBlockV3 always. ( #6300 )
...
* Remove fallback path to publishBlockV2(), use publishBlockV3().
* Update AllTests.md.
2024-05-22 00:03:38 +02:00
Eugene Kabanov
d7c5bc0397
[VC] Add builderBoostFactor support. ( #6294 )
...
* Initial commit.
* Replace localBlockValueBoost with builderBoostFactor.
* Add test.
* Update AllTests.
* Update options.md
* Recover `localBlockValueBoost` for BN-only mode.
* Address review comments.
2024-05-19 04:49:43 +03:00
Jacek Sieka
d191b35e2e
electra: attestatoin sending ( #6296 )
2024-05-17 17:34:46 +02:00
Jacek Sieka
045c4cf185
electra attestation updates ( #6295 )
...
* electra attestation updates
In Electra, we have two attestation formats: on-chain and on-network -
the former combines all committees of a slot in a single committee bit
list.
This PR makes a number of cleanups to move towards fixing this -
attestation packing however still needs to be fixed as it currently
creates attestations with a single committee only which is very
inefficient.
* more attestations in the blocks
* signing and aggregation fixes
* tool fix
* test, import
2024-05-17 15:37:41 +03:00
tersec
826bf4c3ee
be more optimistic about electra
2024-05-17 07:13:30 +00:00
Eugene Kabanov
41db536d63
Fix el-manager warnings and issues. ( #6293 )
2024-05-16 13:54:51 +02:00
tersec
4355f81731
temporarily disable optimistic block hashing on electra
2024-05-16 11:17:31 +00:00
tersec
c7b916fe7b
rename depositReceipts/exits to depositRequests/withdrawalRequests
2024-05-16 00:23:00 +00:00
tersec
b9151d43ce
produce blobs in electra
2024-05-15 14:49:57 +00:00
tersec
111e5d8006
add push raises to nimbus_light_client
2024-05-15 14:01:52 +00:00
tersec
69f13eaa51
add electra gossip transition
2024-05-15 13:30:49 +00:00
Eugene Kabanov
0b8cb4efc4
Add metrics to all RPC {state_id} endpoints. ( #6282 )
2024-05-15 09:52:57 +03:00
tersec
d0400e408b
rename ExitV1 to WithdrawalRequestV1 ( #6290 )
2024-05-15 06:44:52 +02:00
tersec
c0601608f9
rm future_combinators ( #6289 )
2024-05-14 22:14:26 +02:00
tersec
0ca5211f6a
enable nbn electra block processing ( #6288 )
2024-05-14 20:29:03 +02:00
Eugene Kabanov
e6b9bfc9e4
el_manager initial refactor. ( #6228 )
...
* Initial commit.
* Address review comments and fix missing primitive.
* Fix developer build.
* More asyncraises updates.
* Refactor and optimize forkchoiceUpdated() and sendNewPayload().
* Fix runtime assertion.
* Refactor getPayload().
2024-05-14 21:03:30 +03:00
tersec
c1b9e82502
electra attestation gossip plumbing ( #6287 )
2024-05-14 19:01:26 +03:00
tersec
1c3aaa7be2
add (Signed)AggregateAndProof SSZ tests ( #6285 )
2024-05-14 13:51:06 +02:00
tersec
9c669cf57a
some debugRaiseAssert to debugComment; unblock some spec tests ( #6284 )
2024-05-14 12:19:24 +03:00
tersec
3f972a2ca5
add some support for electra aggregated attestations ( #6283 )
2024-05-14 06:12:35 +02:00
Etan Kissling
87605d08a7
bump `nim-eth` to `c482b4c5b658a77cc96b49d4a397aa6d98472ac7` ( #6281 )
...
- Introduce wrapper type for EIP-4844 transactions
2024-05-13 17:58:47 +02:00
tersec
6b8061b5d6
automated consensus spec URL updating to v1.5.0-alpha.2 ( #6279 )
2024-05-09 05:03:10 +00:00
tersec
963e0bb92b
use EF consensus spec v1.5.0-alpha.2 test vectors ( #6272 )
2024-05-08 04:43:05 +02:00
tersec
1b30dcc165
initial electra attestation pool changes; electra block_sim ( #6255 )
2024-05-07 15:01:51 +00:00
tersec
c41fe698cf
small datatypes cleanups ( #6266 )
2024-05-06 10:21:37 +02:00
Eugene Kabanov
a6f68d3edc
Fix POST to /eth/v2/beacon/blocks unable to verify correct block signature. ( #6261 )
2024-05-06 04:15:17 +00:00
Eugene Kabanov
484f48953b
Fix POST to eth/v1/builder/blinded_blocks missing header Eth-Consensus-Version. ( #6256 )
...
* Fix submitBlindededBlock() do not send consensus-version HTTP header.
* Address review comments.
2024-05-03 01:08:16 +00:00
Eugene Kabanov
c9b54bf1aa
Enable IPv6 for discovery5 using dualstack support. ( #6242 )
...
* Make listen-address default to use dualstack.
* Use correct newProtocol().
* Bump nim-eth.
* Bump nim-eth one more time.
* Use `*` instead of IPv6 address for dualstack sockets.
* Bump chronos and nim-eth.
* Use new constructor.
* Fix listenAddress should be Opt[T] not Option[T].
* Fix options.md.
2024-05-01 19:29:39 +00:00
Eugene Kabanov
f3da063510
Fix VC not properly handled getAggregatedAttestation's 404 error. ( #6254 )
...
* Fix VC not properly handled getAggregatedAttestation's 404 error.
* Update AllTests.
2024-05-01 15:32:28 +00:00
tersec
1ab6f1654f
Merge remote-tracking branch 'origin/stable' into unstable
2024-04-29 06:08:43 +00:00
tersec
e70fa6d6de
rename ElectraIndexedAttestation/ElectraAttesterSlashing for consistency ( #6252 )
2024-04-29 04:19:10 +02:00
tersec
f20a21c015
v24.4.0
2024-04-29 01:00:13 +00:00
tersec
abc8bbbf23
add EF consensus spec test Electra fork and transition fixtures ( #6251 )
2024-04-28 16:13:17 +02:00
tersec
a66876c8e5
add EF consensus spec test Electra block sanity fixtures ( #6250 )
...
* add EF consensus spec test Electra block sanity fixtures
* move process_consolidation/process_deposit_receipt before usage
2024-04-28 09:15:03 +00:00
tersec
302f645a01
use EF consensus spec v1.5.0-alpha.1 test vectors ( #6249 )
2024-04-28 03:33:44 +00:00
tersec
6119389c3a
add EF consensus spec test Electra attestation operations fixture ( #6248 )
2024-04-28 00:52:14 +00:00
tersec
8f0a61b964
add EF consensus spec test Electra execution payload operations fixture ( #6246 )
2024-04-26 16:02:15 +00:00
tersec
63d00931a3
add EF consensus spec test Electra deposit receipt operations fixture ( #6245 )
2024-04-26 12:39:09 +00:00
tersec
34ba05f4d3
add EF consensus spec test Electra deposits operations fixture ( #6243 )
2024-04-26 07:18:44 +00:00
tersec
b0f58a58b6
add EF consensus spec test Electra consolidation operations fixture ( #6235 )
2024-04-25 18:50:54 +00:00
tersec
8c4ddd64c0
add EF consensus spec test attester slashing, proposer slashing, voluntary exit, and execution layer withdrawal request tests ( #6234 )
2024-04-25 08:41:17 +00:00
tersec
f53271eaaa
add rest of EF consensus spec test Electra epoch transition fixture(s) ( #6232 )
2024-04-24 12:28:47 +00:00
tersec
e6e95cbab7
add Electra slot sanity tests ( #6230 )
2024-04-23 07:58:32 +00:00
tersec
eb997f4e1f
add 10 sub-test-fixtures for electra epoch transitions; use v2.0.4 for Nim 2.x ( #6229 )
2024-04-23 01:15:55 +00:00
tersec
87452374e4
add Electra SSZ object test fixture ( #6225 )
2024-04-22 09:00:38 +00:00