From f9468ecc2479652ea2716b17960e8a33177acd39 Mon Sep 17 00:00:00 2001 From: cheatfate Date: Thu, 13 Oct 2022 14:38:33 +0300 Subject: [PATCH] Fix MEV builder file descriptor leaks. --- beacon_chain/nimbus_beacon_node.nim | 4 +--- beacon_chain/spec/mev/rest_bellatrix_mev_calls.nim | 8 ++++---- vendor/nim-presto | 2 +- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/beacon_chain/nimbus_beacon_node.nim b/beacon_chain/nimbus_beacon_node.nim index 023dd2f6b..d345e1b2c 100644 --- a/beacon_chain/nimbus_beacon_node.nim +++ b/beacon_chain/nimbus_beacon_node.nim @@ -710,9 +710,7 @@ proc init*(T: type BeaconNode, let payloadBuilderRestClient = if config.payloadBuilderEnable: - RestClientRef.new( - config.payloadBuilderUrl, - httpFlags = {HttpClientFlag.NewConnectionAlways}).valueOr: + RestClientRef.new(config.payloadBuilderUrl).valueOr: warn "Payload builder REST client setup failed", payloadBuilderUrl = config.payloadBuilderUrl nil diff --git a/beacon_chain/spec/mev/rest_bellatrix_mev_calls.nim b/beacon_chain/spec/mev/rest_bellatrix_mev_calls.nim index e582f58f6..ed5a1dffe 100644 --- a/beacon_chain/spec/mev/rest_bellatrix_mev_calls.nim +++ b/beacon_chain/spec/mev/rest_bellatrix_mev_calls.nim @@ -18,7 +18,7 @@ export chronos, client, rest_types, eth2_rest_serialization proc registerValidator*(body: seq[SignedValidatorRegistrationV1] ): RestPlainResponse {. rest, endpoint: "/eth/v1/builder/validators", - meth: MethodPost.} + meth: MethodPost, connection: {Dedicated, Close}.} ## https://github.com/ethereum/builder-specs/blob/v0.2.0/apis/builder/validators.yaml ## https://github.com/ethereum/beacon-APIs/blob/master/apis/validator/register_validator.yaml @@ -27,16 +27,16 @@ proc getHeader*(slot: Slot, pubkey: ValidatorPubKey ): RestResponse[GetHeaderResponse] {. rest, endpoint: "/eth/v1/builder/header/{slot}/{parent_hash}/{pubkey}", - meth: MethodGet.} + meth: MethodGet, connection: {Dedicated, Close}.} ## https://github.com/ethereum/builder-specs/blob/v0.2.0/apis/builder/header.yaml proc submitBlindedBlock*(body: SignedBlindedBeaconBlock ): RestResponse[SubmitBlindedBlockResponse] {. rest, endpoint: "/eth/v1/builder/blinded_blocks", - meth: MethodPost.} + meth: MethodPost, connection: {Dedicated, Close}.} ## https://github.com/ethereum/builder-specs/blob/v0.2.0/apis/builder/blinded_blocks.yaml proc checkBuilderStatus*(): RestPlainResponse {. rest, endpoint: "/eth/v1/builder/status", - meth: MethodGet.} + meth: MethodGet, connection: {Dedicated, Close}.} ## https://github.com/ethereum/builder-specs/blob/v0.2.0/apis/builder/status.yaml diff --git a/vendor/nim-presto b/vendor/nim-presto index 545849eeb..8bc34dd6f 160000 --- a/vendor/nim-presto +++ b/vendor/nim-presto @@ -1 +1 @@ -Subproject commit 545849eebe62f1e0c747d93ea330562be6d44455 +Subproject commit 8bc34dd6f60b6bfe22049323100355671e4137a2