status-im/nimbus-eth2
2
0
Fork 0
mirror of https://github.com/status-im/nimbus-eth2.git synced 2025-02-21 02:38:23 +00:00
Code Issues Projects Releases Wiki Activity

Fix a mysterious Makefile issue

Browse Source 
The GIT_REVISION variable was being set to "" by default.
This commit is contained in:
Zahary Karadjov 2019-10-29 02:54:40 +02:00
parent 34737b48f0
commit f7eb924518
No known key found for this signature in database
GPG Key ID: C8936F8A3073D609
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docker/Makefile
View File

@ -1,6 +1,6 @@
# These default settings can be overriden by exporting env variables # These default settings can be overriden by exporting env variables
GIT_REVISION ?= $(git rev-parse HEAD) GIT_REVISION ?= $(shell git rev-parse HEAD)
NETWORK ?= testnet1 NETWORK ?= testnet1
NETWORK_TYPE ?= libp2p NETWORK_TYPE ?= libp2p
@ -8,7 +8,7 @@ NETWORK_TYPE ?= libp2p
IMAGE_TAG ?= $(NETWORK) IMAGE_TAG ?= $(NETWORK)
IMAGE_NAME ?= statusteam/nimbus_beacon_node:$(IMAGE_TAG) IMAGE_NAME ?= statusteam/nimbus_beacon_node:$(IMAGE_TAG)
build: $(NIX_INSTALL) build:
docker build \ docker build \
--build-arg="GIT_REVISION=$(GIT_REVISION)" \ --build-arg="GIT_REVISION=$(GIT_REVISION)" \
--build-arg="NETWORK=$(NETWORK)" \ --build-arg="NETWORK=$(NETWORK)" \