status-im/nimbus-eth2
2
0
Fork 0
mirror of https://github.com/status-im/nimbus-eth2.git synced 2025-01-13 15:55:20 +00:00
Code Issues Projects Releases Wiki Activity

align sync contribution logs with aggregate processing (#5770)

Browse Source 
There are two conditions leading to `duplicate contribution` log.
Align the logs with the ones used for attestation aggregates,
so that the two conditions can be separated when reading logs.
This commit is contained in:
Etan Kissling 2024-01-17 15:46:54 +01:00 committed by GitHub
parent d5785677a8
commit f409ed97ae
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
beacon_chain/gossip_processing/gossip_validation.nim
View File

@ -899,7 +899,7 @@ proc validateAggregate*(
# `hash_tree_root(aggregate.data)` whose `aggregation_bits` is a non-strict
# superset has _not_ already been seen.
# https://github.com/ethereum/consensus-specs/pull/2847
return errIgnore("Aggregate already covered")
return errIgnore("Aggregate: already covered")
# [REJECT] aggregate_and_proof.selection_proof selects the validator as an
# aggregator for the slot -- i.e. is_aggregator(state, aggregate.data.slot,
@ -1281,7 +1281,7 @@ proc validateContribution*(
# (this requires maintaining a cache of size SYNC_COMMITTEE_SIZE for this
# topic that can be flushed after each slot).
if syncCommitteeMsgPool[].isSeen(msg.message):
return errIgnore("Contribution: duplicate contribution")
return errIgnore("Contribution: validator has already aggregated in slot")
# [REJECT] The aggregator's validator index is in the declared subcommittee
# of the current sync committee.
@ -1317,7 +1317,7 @@ proc validateContribution*(
# `beacon_block_root` and `subcommittee_index` whose `aggregation_bits`
# is non-strict superset has _not_ already been seen.
if syncCommitteeMsgPool[].covers(msg.message.contribution, blck.bid):
return errIgnore("Contribution: duplicate contribution")
return errIgnore("Contribution: already covered")
let sig = if checkSignature:
let deferredCrypto = batchCrypto.scheduleContributionChecks(