status-im/nimbus-eth2
2
0
Fork 0
mirror of https://github.com/status-im/nimbus-eth2.git synced 2025-02-21 02:38:23 +00:00
Code Issues Projects Releases Wiki Activity

rm: TODO comment, revisiting later

Browse Source
This commit is contained in:
Agnish Ghosh 2024-06-15 10:29:43 +05:30
parent 5934400106
commit ebe9b3b4f8
No known key found for this signature in database
GPG Key ID: 7E927C221EBA4F6E
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
beacon_chain/sync/sync_protocol.nim
View File

@ -397,18 +397,7 @@ p2pProtocol BeaconSync(version = 1,
response: MultipleChunksResponse[
ref DataColumnSidecar, Limit(MAX_REQUEST_DATA_COLUMNS)])
{.async, libp2pProtocol("data_column_sidecars_by_root", 1).} =
# TODO Semantically, this request should return a non-ref, but doing so
# runs into extreme inefficiency due to the compiler introducing
# hidden copies - in future nim versions with move support, this should
# be revisited
# TODO This code is more complicated than it needs to be, since the type
# of the multiple chunks response is not actually used in this server
# implementation (it's used to derive the signature of the client
# function, not in the code below!)
# TODO although you can't tell from this function definition, a magic
# client call that returns `seq[ref BlobSidecar]` will
# will be generated by the libp2p macro - we guarantee that seq items
# are `not-nil` in the implementation
trace "got data columns range request", peer, len = columnIds.len
if columnIds.len == 0:
raise newException(InvalidInputsError, "No data columns requested")