status-im
/
nimbus-eth2
mirror of https://github.com/status-im/nimbus-eth2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

make sure `clearanceState` builds on top of `headState` in chain stall (#6108) 

The `clearanceState` points to the latest resolved block, regardless of
whether that block is canonical according to fork choice. If chain is
stalled and we want to prepare for resuming validator duties, we need
a recent state according to fork choice to avoid lag spikes and missing
slot timings.
This commit is contained in:
Etan Kissling 2024-03-20 16:41:56 +01:00 committed by GitHub
parent e75b209076
commit eb5acdb7dd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
beacon_chain/consensus_object_pools/block_clearance.nim
View File

@ -143,6 +143,12 @@ proc advanceClearanceState*(
# epoch transition ahead of time. # epoch transition ahead of time.
# Notably, we use the clearance state here because that's where the block will # Notably, we use the clearance state here because that's where the block will
# first be seen - later, this state will be copied to the head state! # first be seen - later, this state will be copied to the head state!
if chainIsDegraded and dag.clearanceState.latest_block_id != dag.head.bid:
# The last block that was resolved may not be canonical.
# If that's the case, we first have to copy `headState` to `clearanceState`
assign(dag.clearanceState, dag.headState)
let advanced = withState(dag.clearanceState): let advanced = withState(dag.clearanceState):
forkyState.data.slot > forkyState.data.latest_block_header.slot forkyState.data.slot > forkyState.data.latest_block_header.slot
if not advanced or chainIsDegraded: if not advanced or chainIsDegraded: