From ea1acd7397a124c6801f6690c2aca13dedaaf80f Mon Sep 17 00:00:00 2001
From: Jacek Sieka <jacek@status.im>
Date: Sat, 19 Mar 2022 12:02:17 +0100
Subject: [PATCH] fix loading when finalized checkpoint slot is missing block
 (#3525)

ref loop would stop one block early in this case - trying to load
everything in one loop ends up being pretty confusing..

* simplify finalizedBlocks topup by splitting it from the head loop /
query
---
 .../consensus_object_pools/blockchain_dag.nim | 37 +++++++++++--------
 1 file changed, 21 insertions(+), 16 deletions(-)

diff --git a/beacon_chain/consensus_object_pools/blockchain_dag.nim b/beacon_chain/consensus_object_pools/blockchain_dag.nim
index 147f7c39a..d1284ac42 100644
--- a/beacon_chain/consensus_object_pools/blockchain_dag.nim
+++ b/beacon_chain/consensus_object_pools/blockchain_dag.nim
@@ -684,22 +684,6 @@ proc init*(T: type ChainDAGRef, cfg: RuntimeConfig, db: BeaconChainDB,
   # Load head -> finalized, or all summaries in case the finalized block table
   # hasn't been written yet
   for blck in db.getAncestorSummaries(head.root):
-    if blck.summary.slot <= finalizedSlot:
-      if db.finalizedBlocks.high.isNone or
-          blck.summary.slot > db.finalizedBlocks.high.get():
-        # Versions prior to 1.7.0 did not store finalized blocks in the
-        # database, and / or the application might have crashed between the head
-        # and finalized blocks updates.
-        newFinalized.add(BlockId(slot: blck.summary.slot, root: blck.root))
-
-        if blck.summary.slot < finalizedSlot:
-          continue
-
-      if blck.summary.slot < finalizedSlot:
-        # Only non-finalized blocks get a `BlockRef` - if we don't have
-        # finalized blocks to top up, we can stop the iteration here
-        break
-
     let newRef = BlockRef.init(blck.root, blck.summary.slot)
     if headRef == nil:
       doAssert blck.root == head.root
@@ -743,6 +727,10 @@ proc init*(T: type ChainDAGRef, cfg: RuntimeConfig, db: BeaconChainDB,
       if not foundHeadState:
         headBlocks.add curRef
 
+    if curRef.slot <= finalizedSlot:
+      # Only non-finalized slots get a `BlockRef`
+      break
+
   let summariesTick = Moment.now()
 
   if not foundHeadState:
@@ -776,6 +764,23 @@ proc init*(T: type ChainDAGRef, cfg: RuntimeConfig, db: BeaconChainDB,
   doAssert dag.finalizedHead.blck.parent == nil,
     "...but that's the last BlockRef with a parent"
 
+  block: # Top up finalized blocks
+    if db.finalizedBlocks.high.isNone or
+        db.finalizedBlocks.high.get() < dag.finalizedHead.blck.slot:
+      info "Loading finalized blocks",
+        finHigh = db.finalizedBlocks.high,
+          finalizedHead = shortLog(dag.finalizedHead)
+
+      for blck in db.getAncestorSummaries(dag.finalizedHead.blck.root):
+        if db.finalizedBlocks.high.isSome and
+            blck.summary.slot <= db.finalizedBlocks.high.get:
+          break
+
+        # Versions prior to 1.7.0 did not store finalized blocks in the
+        # database, and / or the application might have crashed between the head
+        # and finalized blocks updates.
+        newFinalized.add(BlockId(slot: blck.summary.slot, root: blck.root))
+
   let finalizedBlocksTick = Moment.now()
   db.updateFinalizedBlocks(newFinalized)