From e7d2ee7cb6085846dc94b1c9a78648184e2b9760 Mon Sep 17 00:00:00 2001
From: Etan Kissling <etan@status.im>
Date: Sun, 18 Feb 2024 00:27:49 +0100
Subject: [PATCH] exception handling in `block_sim` (#5906)

There were a few missing exception handlers in the `block_sim` dev tool.
Add them now, and also remove `strformat` dependency for modernization.
---
 research/block_sim.nim | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/research/block_sim.nim b/research/block_sim.nim
index 50ee42563..7decd40e0 100644
--- a/research/block_sim.nim
+++ b/research/block_sim.nim
@@ -5,6 +5,8 @@
 #   * Apache v2 license (license terms in the root directory or at https://www.apache.org/licenses/LICENSE-2.0).
 # at your option. This file may not be copied, modified, or distributed except according to those terms.
 
+{.push raises: [].}
+
 # `block_sim` is a block, attestation, and sync committee simulator, whose task
 # is to run the beacon chain without considering the network or the wall clock.
 #
@@ -26,7 +28,6 @@ import
 
 from std/random import Rand, gauss, initRand, rand
 from std/stats import RunningStat
-from std/strformat import `&`
 from ../beacon_chain/consensus_object_pools/attestation_pool import
   AttestationPool, addAttestation, addForkChoice, getAttestationsForBlock,
   init, prune
@@ -167,7 +168,11 @@ cli do(slots = SLOTS_PER_EPOCH * 7,
     dag = ChainDAGRef.init(cfg, db, validatorMonitor, {})
     eth1Chain = Eth1Chain.init(cfg, db, 0, default Eth2Digest)
     merkleizer = DepositsMerkleizer.init(depositTreeSnapshot.depositContractState)
-    taskpool = Taskpool.new()
+    taskpool =
+      try:
+        Taskpool.new()
+      except Exception as exc:
+        raiseAssert "Failed to initialize Taskpool: " & exc.msg
     verifier = BatchVerifier.init(rng, taskpool)
     quarantine = newClone(Quarantine.init())
     attPool = AttestationPool.init(dag, quarantine)
@@ -252,7 +257,7 @@ cli do(slots = SLOTS_PER_EPOCH * 7,
             validator_index: uint64 validatorIdx,
             signature: signature.toValidatorSig)
 
-        let res = waitFor dag.validateSyncCommitteeMessage(
+        let res = waitFor noCancel dag.validateSyncCommitteeMessage(
           quarantine,
           batchCrypto,
           syncCommitteePool,
@@ -305,7 +310,7 @@ cli do(slots = SLOTS_PER_EPOCH * 7,
               fork, genesis_validators_root, contributionAndProof,
               validatorPrivKey).toValidatorSig)
 
-          res = waitFor dag.validateContribution(
+          res = waitFor noCancel dag.validateContribution(
             quarantine,
             batchCrypto,
             syncCommitteePool,
@@ -485,10 +490,12 @@ cli do(slots = SLOTS_PER_EPOCH * 7,
     verifyConsensus(dag.headState, attesterRatio * blockRatio)
 
     if t == tEpoch:
-      echo &". slot: {shortLog(slot)} ",
-        &"epoch: {shortLog(slot.epoch)}"
+      echo ". slot: ", shortLog(slot), "epoch: ", shortLog(slot.epoch)
     else:
-      write(stdout, ".")
+      try:
+        write(stdout, ".")
+      except IOError:
+        discard
       flushFile(stdout)
 
   if replay: