status-im
/
nimbus-eth2
mirror of https://github.com/status-im/nimbus-eth2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Use environment variables (#176) 

Passing along no-name command line arguments when using make (from Nimbus) would need make target revamps that are a bit clumsy AFAIK, so using environment variables in the spirit of USE_MULTITAIL to get the number of validators and nodes makes more sense to me.

This lets us run the sim from nim-beacon-chain with

```bash
VALIDATORS=512 NODES=100 USE_MULTITAIL="yes" tests/simulation/start.sh
```

and from Nimbus with:

```bash
VALIDATORS=512 NODES=100 USE_MULTITAIL="yes" make eth2_network_simulation
```

Also makes for a more verbose launch process.
This commit is contained in:
Bruno Škvorc 2019-03-13 13:44:30 +01:00 committed by Jacek Sieka
parent 1479bae22f
commit e69702bab5
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/simulation/start.sh
View File

@ -10,8 +10,8 @@ trap "trap - SIGTERM && kill -- -$$" SIGINT SIGTERM EXIT
# Set a default value for the env vars usually supplied by nimbus Makefile # Set a default value for the env vars usually supplied by nimbus Makefile
NUM_VALIDATORS=${1:-100} NUM_VALIDATORS=${VALIDATORS:-100}
NUM_NODES=${2:-9} NUM_NODES=${NODES:-9}
cd $SIM_ROOT cd $SIM_ROOT
mkdir -p "$SIMULATION_DIR" mkdir -p "$SIMULATION_DIR"