status-im
/
nimbus-eth2
mirror of https://github.com/status-im/nimbus-eth2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Stronger validation for third-party Eth1Data votes

This commit is contained in:
Zahary Karadjov 2021-05-01 02:00:03 +03:00 committed by zah
parent 9d031a8446
commit e60dd8e4f6
1 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
beacon_chain/eth1/eth1_monitor.nim
View File

@ -672,21 +672,17 @@ proc getBlockProposalData*(chain: var Eth1Chain,
var otherVotesCountTable = initCountTable[Eth1Data]() var otherVotesCountTable = initCountTable[Eth1Data]()
for vote in state.eth1_data_votes: for vote in state.eth1_data_votes:
let eth1Block = chain.findBlock(vote) let eth1Block = chain.findBlock(vote)
if eth1Block == nil: if eth1Block != nil and
continue eth1Block.voteData.deposit_root == vote.deposit_root and
let vote.deposit_count >= state.eth1_data.deposit_count and
isSuccessor = vote.deposit_count >= state.eth1_data.deposit_count is_candidate_block(chain.preset, eth1Block, periodStart):
# TODO(zah)
# There is a slight deviation from the spec here to deal with the following
# problem: the in-memory database of eth1 blocks for a restarted node will
# be empty which will lead a "no change" vote. To fix this, we'll need to
# add rolling persistance for all potentially voted on blocks.
isCandidate = (is_candidate_block(chain.preset, eth1Block, periodStart))
if isSuccessor and isCandidate:
otherVotesCountTable.inc vote otherVotesCountTable.inc vote
else: else:
debug "Ignoring eth1 vote", root = vote.block_hash, isSuccessor, isCandidate debug "Ignoring eth1 vote",
root = vote.block_hash,
deposits = vote.deposit_count,
depositsRoot = vote.deposit_root,
localDeposits = state.eth1_data.deposit_count
var pendingDepositsCount = state.eth1_data.deposit_count - state.eth1_deposit_index var pendingDepositsCount = state.eth1_data.deposit_count - state.eth1_deposit_index
if otherVotesCountTable.len > 0: if otherVotesCountTable.len > 0: