diff --git a/AllTests-mainnet.md b/AllTests-mainnet.md index 63eb22f49..96e71c1e0 100644 --- a/AllTests-mainnet.md +++ b/AllTests-mainnet.md @@ -154,6 +154,7 @@ OK: 1/1 Fail: 0/1 Skip: 0/1 OK: 2/2 Fail: 0/2 Skip: 0/2 ## EF - KZG ```diff ++ KZG - Blob to KZG commitment - blob_to_kzg_commitment_case_invalid_blob_59d64ff6b4648fad OK + KZG - Blob to KZG commitment - blob_to_kzg_commitment_case_invalid_blob_635fb2de5b0dc429 OK + KZG - Blob to KZG commitment - blob_to_kzg_commitment_case_invalid_blob_a3b9ff28507767f8 OK + KZG - Blob to KZG commitment - blob_to_kzg_commitment_case_invalid_blob_d3afbd98123a3434 OK @@ -164,6 +165,7 @@ OK: 2/2 Fail: 0/2 Skip: 0/2 + KZG - Blob to KZG commitment - blob_to_kzg_commitment_case_valid_blob_c40b9b515df8721b OK + KZG - Blob to KZG commitment - blob_to_kzg_commitment_case_valid_blob_cdb3e6d49eb12307 OK + KZG - Blob to KZG commitment - blob_to_kzg_commitment_case_valid_blob_fb324bc819407148 OK ++ KZG - Compute KZG proof - compute_kzg_proof_case_invalid_blob_59d64ff6b4648fad OK + KZG - Compute KZG proof - compute_kzg_proof_case_invalid_blob_635fb2de5b0dc429 OK + KZG - Compute KZG proof - compute_kzg_proof_case_invalid_blob_a3b9ff28507767f8 OK + KZG - Compute KZG proof - compute_kzg_proof_case_invalid_blob_d3afbd98123a3434 OK @@ -172,6 +174,7 @@ OK: 2/2 Fail: 0/2 Skip: 0/2 + KZG - Compute KZG proof - compute_kzg_proof_case_invalid_z_8e021fdb13259641 OK + KZG - Compute KZG proof - compute_kzg_proof_case_invalid_z_9683af102559ddf0 OK + KZG - Compute KZG proof - compute_kzg_proof_case_invalid_z_9df8c89b61183887 OK ++ KZG - Compute KZG proof - compute_kzg_proof_case_invalid_z_b30d81e81c1262b6 OK + KZG - Compute KZG proof - compute_kzg_proof_case_valid_blob_02e696ada7d4631d OK + KZG - Compute KZG proof - compute_kzg_proof_case_valid_blob_05c1f3685f3393f0 OK + KZG - Compute KZG proof - compute_kzg_proof_case_valid_blob_08f9e2f1cb3d39db OK @@ -214,12 +217,14 @@ OK: 2/2 Fail: 0/2 Skip: 0/2 + KZG - Compute KZG proof - compute_kzg_proof_case_valid_blob_f47eb9fc139f6bfd OK + KZG - Compute KZG proof - compute_kzg_proof_case_valid_blob_f7f44e1e864aa967 OK + KZG - Compute KZG proof - compute_kzg_proof_case_valid_blob_ffa6e97b97146517 OK ++ KZG - Compute blob KZG proof - compute_blob_kzg_proof_case_invalid_blob_59d64ff6b4648fad OK + KZG - Compute blob KZG proof - compute_blob_kzg_proof_case_invalid_blob_635fb2de5b0dc429 OK + KZG - Compute blob KZG proof - compute_blob_kzg_proof_case_invalid_blob_a3b9ff28507767f8 OK + KZG - Compute blob KZG proof - compute_blob_kzg_proof_case_invalid_blob_d3afbd98123a3434 OK + KZG - Compute blob KZG proof - compute_blob_kzg_proof_case_invalid_commitment_1a68c47b6814 OK + KZG - Compute blob KZG proof - compute_blob_kzg_proof_case_invalid_commitment_24b932fb4dec OK + KZG - Compute blob KZG proof - compute_blob_kzg_proof_case_invalid_commitment_3a6eb616efae OK ++ KZG - Compute blob KZG proof - compute_blob_kzg_proof_case_invalid_commitment_d070689c3e15 OK + KZG - Compute blob KZG proof - compute_blob_kzg_proof_case_valid_blob_0951cfd9ab47a8d3 OK + KZG - Compute blob KZG proof - compute_blob_kzg_proof_case_valid_blob_19b3f3f8c98ea31e OK + KZG - Compute blob KZG proof - compute_blob_kzg_proof_case_valid_blob_84d8089232bc23a8 OK @@ -403,7 +408,7 @@ OK: 2/2 Fail: 0/2 Skip: 0/2 + KZG - Verify blob KZG proof batch - verify_blob_kzg_proof_batch_case_invalid_proof_d070689 OK + KZG - Verify blob KZG proof batch - verify_blob_kzg_proof_batch_case_proof_length_differen OK ``` -OK: 248/248 Fail: 0/248 Skip: 0/248 +OK: 253/253 Fail: 0/253 Skip: 0/253 ## EF - SSZ generic types ```diff Testing basic_vector inputs - invalid Skip @@ -974,4 +979,4 @@ OK: 2/2 Fail: 0/2 Skip: 0/2 OK: 9/9 Fail: 0/9 Skip: 0/9 ---TOTAL--- -OK: 659/664 Fail: 0/664 Skip: 5/664 +OK: 664/669 Fail: 0/669 Skip: 5/669 diff --git a/tests/consensus_spec/test_fixture_kzg.nim b/tests/consensus_spec/test_fixture_kzg.nim index 1e9af2016..67478911a 100644 --- a/tests/consensus_spec/test_fixture_kzg.nim +++ b/tests/consensus_spec/test_fixture_kzg.nim @@ -19,6 +19,10 @@ from std/sequtils import anyIt, mapIt, toSeq from std/strutils import rsplit func fromHex[N: static int](s: string): Opt[array[N, byte]] = + if s.len != 2*(N+1): + # 0x prefix + return Opt.none array[N, byte] + try: Opt.some fromHex(array[N, byte], s) except ValueError: @@ -189,9 +193,6 @@ suite suiteName: block: let testsDir = suitePath/"blob_to_kzg_commitment"/"kzg-mainnet" for kind, path in walkDir(testsDir, relative = true, checkDir = true): - # TODO Trying to access value with err Result [ResultDefect] - if path == "blob_to_kzg_commitment_case_invalid_blob_59d64ff6b4648fad": - continue runBlobToKzgCommitmentTest(suiteName, testsDir, testsDir/path) block: @@ -212,23 +213,11 @@ suite suiteName: block: let testsDir = suitePath/"compute_kzg_proof"/"kzg-mainnet" for kind, path in walkDir(testsDir, relative = true, checkDir = true): - # TODO in both cases, it's not properly detecting invalid input and - # creating an actual proof/y pair instead of an error - if path in [ - "compute_kzg_proof_case_invalid_blob_59d64ff6b4648fad", - "compute_kzg_proof_case_invalid_z_b30d81e81c1262b6"]: - continue runComputeKzgProofTest(suiteName, testsDir, testsDir / path) block: let testsDir = suitePath/"compute_blob_kzg_proof"/"kzg-mainnet" for kind, path in walkDir(testsDir, relative = true, checkDir = true): - # TODO in one case the same case as before, and maybe the invalid - # commitment too - if path in [ - "compute_blob_kzg_proof_case_invalid_blob_59d64ff6b4648fad", - "compute_blob_kzg_proof_case_invalid_commitment_d070689c3e15444c"]: - continue runComputeBlobKzgProofTest(suiteName, testsDir, testsDir / path) doAssert Kzg.freeTrustedSetup().isOk