status-im/nimbus-eth2
2
0
Fork 0
mirror of https://github.com/status-im/nimbus-eth2.git synced 2025-01-14 00:29:04 +00:00
Code Issues Projects Releases Wiki Activity

log engine/builder API decisionmaking (#5608)

Browse Source
This commit is contained in:
tersec 2023-12-15 20:31:14 +00:00 committed by GitHub
parent 0b9c632b69
commit cb6b54ec89
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
beacon_chain/validators/beacon_validators.nim
View File

@ -1093,6 +1093,38 @@ proc proposeBlockAux(
return head # errors logged in router
false
# There should always be an engine bid, and if payloadBuilderClient exists,
# not getting a builder bid is also an error. Do not report lack of builder
# when that's intentional. Replicate some of the nested if statements here,
# because that avoids entangling logging with other functionality. The logs
# here are inteded to clarify that, for example, when the builder API relay
# URL is provided for this validator, it's reasonable for Nimbus not to use
# it for every block.
if collectedBids.engineBidAvailable:
# Three cases: builder bid expected and absent, builder bid expected and
# present, and builder bid not expected.
if collectedBids.builderBidAvailable:
info "Compared engine and builder block bids",
localBlockValueBoost,
useBuilderBlock,
builderBlockValue =
collectedBids.payloadBuilderBidFut.read.get().blockValue,
engineBlockValue = collectedBids.engineBlockFut.read.get().blockValue
elif payloadBuilderClient.isNil:
discard # builder API not configured for this block
else:
info "Did not receive expected builder bid; using engine block",
engineBlockValue = collectedBids.engineBlockFut.read.get().blockValue
else:
# Similar three cases: builder bid expected and absent, builder bid
# expected and present, and builder bid not expected. However, only
# the second is worth logging, because the other two result in this
# block being missed altogether, and with details logged elsewhere.
if collectedBids.builderBidAvailable:
info "Did not receive expected engine bid; using builder block",
builderBlockValue =
collectedBids.payloadBuilderBidFut.read.get().blockValue
if useBuilderBlock:
let
blindedBlock = (await blindedBlockCheckSlashingAndSign(