status-im
/
nimbus-eth2
mirror of https://github.com/status-im/nimbus-eth2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Doppelganger exit code changed from 1031 to 129 (addresses #3973) (#3977)

This commit is contained in:
zah 2022-08-17 09:13:55 +03:00 committed by GitHub
parent fa9e2b4ec4
commit ca3245c4f0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -99,7 +99,7 @@ Nimbus `v22.6.0` brings support for the merge testnets Ropsten and Sepolia (plea
https://github.com/status-im/nimbus-eth2/pull/3679 https://github.com/status-im/nimbus-eth2/pull/3679
https://github.com/status-im/nimbus-eth2/pull/3780 https://github.com/status-im/nimbus-eth2/pull/3780
* The custom error code `1031` will signal a detected doppelganger on the network. This can be handled in the Nimbus's service supervisor to prevent an automatic restart: * The custom error code `129` will signal a detected doppelganger on the network. This can be handled in the Nimbus's service supervisor to prevent an automatic restart:
https://github.com/status-im/nimbus-eth2/pull/3728 https://github.com/status-im/nimbus-eth2/pull/3728
* The Nimbus status bar can be configured to display the current version number: * The Nimbus status bar can be configured to display the current version number:

2
beacon_chain/gossip_processing/eth2_processor.nim
View File

@ -287,7 +287,7 @@ proc checkForPotentialDoppelganger(
# Avoid colliding with # Avoid colliding with
# https://www.freedesktop.org/software/systemd/man/systemd.exec.html#Process%20Exit%20Codes # https://www.freedesktop.org/software/systemd/man/systemd.exec.html#Process%20Exit%20Codes
const QuitDoppelganger = 1031 const QuitDoppelganger = 129
quit QuitDoppelganger quit QuitDoppelganger
proc processAttestation*( proc processAttestation*(

2
docs/the_nimbus_book/src/beacon-node-systemd.md
View File

@ -35,7 +35,7 @@ curl -s https://raw.githubusercontent.com/status-im/nimbus-eth2/stable/scripts/p
The format of service files is documented in the [systemd manual](https://www.freedesktop.org/software/systemd/man/systemd.service.html). The format of service files is documented in the [systemd manual](https://www.freedesktop.org/software/systemd/man/systemd.service.html).
!!! tip !!! tip
Automatic restarts increase the risk that the doppelganger detection fails - set `RestartPreventExitStatus=1031` to prevent this from happening Automatic restarts increase the risk that the doppelganger detection fails - set `RestartPreventExitStatus=129` to prevent this from happening
### 3. Configure your service ### 3. Configure your service

10
docs/the_nimbus_book/src/options.md
View File

@ -144,8 +144,8 @@ Here is an example config file illustrating all of the above:
## Exit Codes ## Exit Codes
| Exit code | Description | | Exit code | Description |
|-----------|---------| |-----------|-----------------------------------------------------------------------|
| 0 | Successful exit | | 0 | Successful exit |
| 1 | Generic failure or unspecified error | | 1 | Generic failure or unspecified error |
| 1031 | Doppelganger detection; one might prefer not to restart automatically | | 129 | Doppelganger detection; one might prefer not to restart automatically |

2
scripts/package_image/usr/lib/systemd/system/nimbus_beacon_node.service
View File

@ -51,7 +51,7 @@ TimeoutSec=1200
Restart=always Restart=always
# Don't restart when Doppelganger detection has been activated # Don't restart when Doppelganger detection has been activated
RestartPreventExitStatus=1031 RestartPreventExitStatus=129
ExecStart=/usr/bin/nimbus_beacon_node \ ExecStart=/usr/bin/nimbus_beacon_node \
--network=${NETWORK} \ --network=${NETWORK} \