status-im/nimbus-eth2
2
0
Fork 0
mirror of https://github.com/status-im/nimbus-eth2.git synced 2025-02-20 02:08:12 +00:00
Code Issues Projects Releases Wiki Activity

Fix an overflow in the justification bits processing

Browse Source
This commit is contained in:
Zahary Karadjov 2019-09-27 19:40:33 +03:00 committed by zah
parent 5a1a878bbd
commit c39d4f1817
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
beacon_chain/spec/state_transition_epoch.nim
View File

@ -200,7 +200,11 @@ proc process_justification_and_finalization*(
## Spec: ## Spec:
## state.justification_bits[1:] = state.justification_bits[:-1] ## state.justification_bits[1:] = state.justification_bits[:-1]
## state.justification_bits[0] = 0b0 ## state.justification_bits[0] = 0b0
state.justification_bits = state.justification_bits shl 1 # TODO JUSTIFICATION_BITS_LENGTH is a constant in spec, move there or fix
# BitVector serialization in SSZ layer
const JUSTIFICATION_BITS_LENGTH = 4
state.justification_bits = (state.justification_bits shl 1) and
cast[uint8]((2^JUSTIFICATION_BITS_LENGTH) - 1)
# This is a somewhat expensive approach # This is a somewhat expensive approach
let active_validator_indices = let active_validator_indices =