deactivate doppelganger protection during genesis (#3362)
* deactivate Doppelganger Protection during genesis * also don't actually flag supposed-doppelgangers (because they're before broadcastStartEpoch) on GENESIS_SLOT start
This commit is contained in:
parent
70579f2fb1
commit
bf3ef987e4
|
@ -78,7 +78,7 @@ type
|
|||
## of gossip interleaving between nodes so long as they don't gossip at
|
||||
## the same time.
|
||||
|
||||
nodeLaunchSlot: Slot ##\
|
||||
nodeLaunchSlot*: Slot ##\
|
||||
## Set once, at node launch. This functions as a basic protection against
|
||||
## false positives from attestations persisting within the gossip network
|
||||
## across quick restarts.
|
||||
|
@ -260,7 +260,8 @@ proc checkForPotentialDoppelganger(
|
|||
return
|
||||
|
||||
if attestation.data.slot.epoch <
|
||||
self.doppelgangerDetection.broadcastStartEpoch:
|
||||
self.doppelgangerDetection.broadcastStartEpoch and
|
||||
self.doppelgangerDetection.nodeLaunchSlot > GENESIS_SLOT:
|
||||
for validatorIndex in attesterIndices:
|
||||
let validatorPubkey = self.dag.validatorKey(validatorIndex).get().toPubKey()
|
||||
if not isNil(self.validatorPool[].getValidator(validatorPubkey)):
|
||||
|
|
|
@ -1029,6 +1029,7 @@ proc handleValidatorDuties*(node: BeaconNode, lastSlot, slot: Slot) {.async.} =
|
|||
# means that it'd be okay not to continue, but it won't gossip regardless.
|
||||
if curSlot.epoch <
|
||||
node.processor[].doppelgangerDetection.broadcastStartEpoch and
|
||||
node.processor[].doppelgangerDetection.nodeLaunchSlot > GENESIS_SLOT and
|
||||
node.config.doppelgangerDetection:
|
||||
let
|
||||
nextAttestationSlot = node.actionTracker.getNextAttestationSlot(slot - 1)
|
||||
|
|
|
@ -1,6 +1,6 @@
|
|||
#!/usr/bin/env bash
|
||||
|
||||
# Copyright (c) 2020-2021 Status Research & Development GmbH. Licensed under
|
||||
# Copyright (c) 2020-2022 Status Research & Development GmbH. Licensed under
|
||||
# either of:
|
||||
# - Apache License, version 2.0
|
||||
# - MIT license
|
||||
|
@ -487,7 +487,6 @@ for NUM_NODE in $(seq 0 $(( NUM_NODES - 1 ))); do
|
|||
--metrics \
|
||||
--metrics-address="127.0.0.1" \
|
||||
--metrics-port="$(( BASE_METRICS_PORT + NUM_NODE ))" \
|
||||
--doppelganger-detection=off \
|
||||
${EXTRA_ARGS} \
|
||||
> "${DATA_DIR}/log${NUM_NODE}.txt" 2>&1 &
|
||||
|
||||
|
|
Loading…
Reference in New Issue