ignore instead of reject duplicate sync msgs (#2903)
The P2P spec defines how certain error classes should be handled through either IGNORE or REJECT verdicts. For sync committee message, the spec defines that only the first message from each validator per subcommittee and slot shall be accepted, the rest is ignored. However, current code rejects those messages instead of ignoring them. Fixed to match spec.
This commit is contained in:
parent
2b2846b468
commit
ba3884f449
|
@ -796,7 +796,7 @@ proc validateSyncCommitteeMessage*(
|
|||
committeeIdx: syncCommitteeIdx)
|
||||
|
||||
if msgKey in syncCommitteeMsgPool.seenSyncMsgByAuthor:
|
||||
return errReject("SyncCommitteeMessage: duplicate message")
|
||||
return errIgnore("SyncCommitteeMessage: duplicate message")
|
||||
else:
|
||||
syncCommitteeMsgPool.seenSyncMsgByAuthor.incl msgKey
|
||||
|
||||
|
|
Loading…
Reference in New Issue