status-im/nimbus-eth2
2
0
Fork 0
mirror of https://github.com/status-im/nimbus-eth2.git synced 2025-01-09 13:56:23 +00:00
Code Issues Projects Releases Wiki Activity

test for correctly skipping, without failure, deposits with invalid signatures (#1288)

Browse Source
This commit is contained in:
tersec 2020-07-08 04:55:23 +00:00 committed by GitHub
parent 6fe0a623f5
commit b7d1967449
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 38 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/mocking/mock_genesis.nim
View File

@ -21,11 +21,11 @@ proc initGenesisState*(num_validators: uint64, genesis_time: uint64 = 0): Hashed
let deposits = mockGenesisBalancedDeposits( let deposits = mockGenesisBalancedDeposits(
validatorCount = num_validators, validatorCount = num_validators,
amountInEth = 32, # We create canonical validators with 32 Eth amountInEth = 32, # We create canonical validators with 32 Eth
flags = {skipBlsValidation} flags = {}
) )
initialize_hashed_beacon_state_from_eth1( initialize_hashed_beacon_state_from_eth1(
eth1BlockHash, 0, deposits, {skipBlsValidation}) eth1BlockHash, 0, deposits, {})
when isMainModule: when isMainModule:
# Smoke test # Smoke test

42
tests/spec_block_processing/test_process_deposits.nim
View File

@ -30,7 +30,6 @@ suiteReport "[Unit - Spec - Block processing] Deposits " & preset():
doAssert genesisState.data.validators.len == int NumValidators doAssert genesisState.data.validators.len == int NumValidators
template valid_deposit(deposit_amount: uint64, name: string): untyped = template valid_deposit(deposit_amount: uint64, name: string): untyped =
# TODO: BLS signature
timedTest "Deposit " & name & " MAX_EFFECTIVE_BALANCE balance (" & timedTest "Deposit " & name & " MAX_EFFECTIVE_BALANCE balance (" &
$(MAX_EFFECTIVE_BALANCE div 10'u64^9) & " ETH)": $(MAX_EFFECTIVE_BALANCE div 10'u64^9) & " ETH)":
var state = assignClone(genesisState[]) var state = assignClone(genesisState[])
@ -42,7 +41,7 @@ suiteReport "[Unit - Spec - Block processing] Deposits " & preset():
state.data, state.data,
uint64 validator_index, uint64 validator_index,
deposit_amount, deposit_amount,
flags = {skipBlsValidation} flags = {}
) )
# Params for sanity checks # Params for sanity checks
@ -55,7 +54,7 @@ suiteReport "[Unit - Spec - Block processing] Deposits " & preset():
# State transition # State transition
# ---------------------------------------- # ----------------------------------------
check: process_deposit(state.data, deposit, {skipBlsValidation}).isOk check: process_deposit(state.data, deposit, {}).isOk
# Check invariants # Check invariants
# ---------------------------------------- # ----------------------------------------
@ -84,7 +83,7 @@ suiteReport "[Unit - Spec - Block processing] Deposits " & preset():
state.data, state.data,
uint64 validator_index, uint64 validator_index,
deposit_amount, deposit_amount,
flags = {skipBlsValidation} flags = {}
) )
# Params for sanity checks # Params for sanity checks
@ -97,7 +96,7 @@ suiteReport "[Unit - Spec - Block processing] Deposits " & preset():
# State transition # State transition
# ---------------------------------------- # ----------------------------------------
check: process_deposit(state.data, deposit, {skipBlsValidation}).isOk check: process_deposit(state.data, deposit, {}).isOk
# Check invariants # Check invariants
# ---------------------------------------- # ----------------------------------------
@ -111,8 +110,39 @@ suiteReport "[Unit - Spec - Block processing] Deposits " & preset():
EFFECTIVE_BALANCE_INCREMENT EFFECTIVE_BALANCE_INCREMENT
) )
template invalid_signature(deposit_amount: uint64, name: string): untyped =
timedTest "Invalid deposit " & name & " MAX_EFFECTIVE_BALANCE balance (" &
$(MAX_EFFECTIVE_BALANCE div 10'u64^9) & " ETH)":
var state = assignClone(genesisState[])
# Test configuration
# ----------------------------------------
let validator_index = state.data.validators.len
var deposit = mockUpdateStateForNewDeposit(
state.data,
uint64 validator_index,
deposit_amount,
flags = {skipBlsValidation}
)
# Params for sanity checks
# ----------------------------------------
let pre_val_count = state.data.validators.len
# State transition
# ----------------------------------------
check:
process_deposit(state.data, deposit, {}).isOk
# Check invariants
# ----------------------------------------
check:
state.data.validators.len == pre_val_count
state.data.balances.len == pre_val_count
invalid_signature(MAX_EFFECTIVE_BALANCE, "at")
# TODO, tests with: # TODO, tests with:
# - invalid BLS signature
# - invalid withdrawal credential # - invalid withdrawal credential
# - invalid deposit root # - invalid deposit root
# - invalid merkle proof # - invalid merkle proof