diff --git a/beacon_chain/consensus_object_pools/block_quarantine.nim b/beacon_chain/consensus_object_pools/block_quarantine.nim index 9849a1349..d6da6d24b 100644 --- a/beacon_chain/consensus_object_pools/block_quarantine.nim +++ b/beacon_chain/consensus_object_pools/block_quarantine.nim @@ -303,7 +303,7 @@ proc addBlobless*( quarantine.cleanupBlobless(finalizedSlot) if quarantine.blobless.lenu64 >= MaxBlobless: - return false + return true debug "block quarantine: Adding blobless", blck = shortLog(signedBlock) quarantine.blobless[signedBlock.root] = signedBlock diff --git a/beacon_chain/gossip_processing/block_processor.nim b/beacon_chain/gossip_processing/block_processor.nim index 3cc34f192..782001fe2 100644 --- a/beacon_chain/gossip_processing/block_processor.nim +++ b/beacon_chain/gossip_processing/block_processor.nim @@ -742,11 +742,8 @@ proc storeBlock( forkyBlck.root, forkyBlck) self[].enqueueBlock(MsgSource.gossip, quarantined, Opt.some(blobs)) else: - if not self.consensusManager.quarantine[].addBlobless( - dag.finalizedHead.slot, forkyBlck): - notice "Block quarantine full (blobless)", - blockRoot = shortLog(quarantined.root), - signature = shortLog(quarantined.signature) + discard self.consensusManager.quarantine[].addBlobless( + dag.finalizedHead.slot, forkyBlck) ok blck.value() diff --git a/beacon_chain/gossip_processing/eth2_processor.nim b/beacon_chain/gossip_processing/eth2_processor.nim index 3d69f4cde..d61bde7cf 100644 --- a/beacon_chain/gossip_processing/eth2_processor.nim +++ b/beacon_chain/gossip_processing/eth2_processor.nim @@ -246,12 +246,8 @@ proc processSignedBeaconBlock*( if self.blobQuarantine[].hasBlobs(signedBlock): Opt.some(self.blobQuarantine[].popBlobs(signedBlock.root, signedBlock)) else: - if not self.quarantine[].addBlobless(self.dag.finalizedHead.slot, - signedBlock): - notice "Block quarantine full (blobless)", - blockRoot = shortLog(signedBlock.root), - blck = shortLog(signedBlock.message), - signature = shortLog(signedBlock.signature) + discard self.quarantine[].addBlobless(self.dag.finalizedHead.slot, + signedBlock) return v else: Opt.none(BlobSidecars)