status-im
/
nimbus-eth2
mirror of https://github.com/status-im/nimbus-eth2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

no verify kzg during addBlock

This commit is contained in:
Agnish Ghosh 2024-08-28 14:29:19 +05:30
parent 66bf20e7f0
commit b573caccc7
1 changed files with 1 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
beacon_chain/gossip_processing/block_processor.nim
View File

@ -636,7 +636,7 @@ proc storeBlock(
# TODO with v1.4.0, not sure this is still relevant # TODO with v1.4.0, not sure this is still relevant
# Establish blob viability before calling addHeadBlock to avoid # Establish blob viability before calling addHeadBlock to avoid
# writing the block in case of blob error. # writing the block in case of blob error.
when typeof(signedBlock).kind >= ConsensusFork.Deneb: # when typeof(signedBlock).kind >= ConsensusFork.Deneb:
# # if blobsOpt.isSome: # # if blobsOpt.isSome:
# # let blobs = blobsOpt.get() # # let blobs = blobsOpt.get()
# # let kzgCommits = signedBlock.message.body.blob_kzg_commitments.asSeq # # let kzgCommits = signedBlock.message.body.blob_kzg_commitments.asSeq
@ -653,31 +653,6 @@ proc storeBlock(
# # msg = r.error() # # msg = r.error()
# # return err((VerifierError.Invalid, ProcessingStatus.completed)) # # return err((VerifierError.Invalid, ProcessingStatus.completed))
if dataColumnsOpt.isSome:
let data_column_sidecars = dataColumnsOpt.get
if data_column_sidecars.len > 0:
for i in 0..<data_column_sidecars.len:
let r = verify_data_column_sidecar_kzg_proofs(data_column_sidecars[i][])
if r.isErr():
debug "data column sidecar verification failed",
blockroot = shortLog(signedBlock.root),
column_sidecar = shortLog(data_column_sidecars[i][]),
blck = shortLog(signedBlock.message),
kzgCommits =
mapIt(data_column_sidecars[i][].kzg_commitments,
shortLog(it)),
signature = shortLog(signedBlock.signature),
msg = r.error
return err((VerifierError.Invalid, ProcessingStatus.completed))
notice "Verified data columns successfully",
blockroot = shortLog(signedBlock.root),
column_sidecar = shortLog(data_column_sidecars[i][]),
blck = shortLog(signedBlock.message),
kzgCommits =
mapIt(data_column_sidecars[i][].kzg_commitments,
shortLog(it))
type Trusted = typeof signedBlock.asTrusted() type Trusted = typeof signedBlock.asTrusted()