diff --git a/beacon_chain/beacon_node.nim b/beacon_chain/beacon_node.nim index 77b573dd6..0f1081815 100644 --- a/beacon_chain/beacon_node.nim +++ b/beacon_chain/beacon_node.nim @@ -28,10 +28,6 @@ declareGauge beacon_head_slot, declareGauge beacon_head_root, "Root of the head block of the beacon chain" -# https://github.com/ethereum/eth2.0-metrics/blob/master/metrics.md#additional-metrics -declareGauge beacon_pending_exits, - "Number of pending voluntary exits in local operation pool" # On slot - # Metrics for tracking attestation and beacon block loss declareCounter beacon_attestations_sent, "Number of beacon chain attestations sent by this peer" @@ -399,7 +395,7 @@ proc proposeBlock(node: BeaconNode, var tmpState = hashedState - let ok = state_transition(tmpState, newBlock, {skipValidation}) + discard state_transition(tmpState, newBlock, {skipValidation}) # TODO only enable in fast-fail debugging situations # otherwise, bad attestations can bring down network # doAssert ok # TODO: err, could this fail somehow? diff --git a/tests/official/test_fixture_operations_deposits.nim b/tests/official/test_fixture_operations_deposits.nim index 58407bdb5..27dd8bec9 100644 --- a/tests/official/test_fixture_operations_deposits.nim +++ b/tests/official/test_fixture_operations_deposits.nim @@ -59,9 +59,9 @@ template runTest(testName: string, identifier: untyped) = if postRef.isNil: expect(AssertionError): - let done = process_deposit(sr_pre[], depositRef[], flags) + discard process_deposit(sr_pre[], depositRef[], flags) else: - let done = process_deposit(sr_pre[], depositRef[], flags) + discard process_deposit(sr_pre[], depositRef[], flags) reportDiff(sr_pre, sr_post) `testImpl _ operations_deposits _ identifier`() diff --git a/tests/official/test_fixture_sanity_blocks.nim b/tests/official/test_fixture_sanity_blocks.nim index f25a83a78..2e984a906 100644 --- a/tests/official/test_fixture_sanity_blocks.nim +++ b/tests/official/test_fixture_sanity_blocks.nim @@ -36,7 +36,6 @@ template runValidTest(testName: string, identifier: untyped, num_blocks: int): u stateRef[] = parseTest(testDir/"pre.ssz", SSZ, BeaconState) postRef[] = parseTest(testDir/"post.ssz", SSZ, BeaconState) - var success = true for i in 0 ..< num_blocks: let blck = parseTest(testDir/"blocks_" & $i & ".ssz", SSZ, BeaconBlock) diff --git a/tests/official/test_fixture_ssz_consensus_objects.nim b/tests/official/test_fixture_ssz_consensus_objects.nim index 8f79e00e9..eaa53630c 100644 --- a/tests/official/test_fixture_ssz_consensus_objects.nim +++ b/tests/official/test_fixture_ssz_consensus_objects.nim @@ -7,7 +7,7 @@ import # Standard library - os, unittest, strutils, streams, strformat, strscans, + os, unittest, strutils, streams, strformat, macros, sets, # Status libraries stint, stew/bitseqs,