status-im/nimbus-eth2
2
0
Fork 0
mirror of https://github.com/status-im/nimbus-eth2.git synced 2025-01-15 17:15:37 +00:00
Code Issues Projects Releases Wiki Activity

fix LC data import --only-new regression (#5616)

Browse Source 
Corrects LC server startup logic for `LightClientDataImportMode.OnlyNew`
after regression in #5607.
This commit is contained in:
Etan Kissling 2023-11-22 14:05:31 +01:00 committed by GitHub
parent 7554ca2583
commit b0b8f21223
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
beacon_chain/consensus_object_pools/blockchain_dag_light_client.nim
View File

@ -764,23 +764,22 @@ proc initLightClientDataCache*(dag: ChainDAGRef) =
initDur = lightClientEndTick - lightClientStartTick, res initDur = lightClientEndTick - lightClientStartTick, res
if res.isErr: if res.isErr:
return return
if dag.lcDataStore.importMode == LightClientDataImportMode.OnDemand:
return
# Import historic data # Import historic data
dag.lcDataStore.cache.tailSlot = targetTailSlot if dag.lcDataStore.importMode == LightClientDataImportMode.Full:
let targetTailPeriod = targetTailSlot.sync_committee_period dag.lcDataStore.cache.tailSlot = targetTailSlot
if targetTailPeriod < finalizedPeriod: let targetTailPeriod = targetTailSlot.sync_committee_period
# `countdown` through 0 fails on distinct `uint64` if targetTailPeriod < finalizedPeriod:
# https://github.com/nim-lang/Nim/pull/19926 # `countdown` through 0 fails on distinct `uint64`
var period = finalizedPeriod - 1 # https://github.com/nim-lang/Nim/pull/19926
while period >= targetTailPeriod: var period = finalizedPeriod - 1
if dag.initLightClientDataForPeriod(period).isErr: while period >= targetTailPeriod:
res.err() if dag.initLightClientDataForPeriod(period).isErr:
if period <= targetTailPeriod: res.err()
break if period <= targetTailPeriod:
dec period break
debug "Historic LC data imported", res dec period
debug "Historic LC data imported", res
proc processNewBlockForLightClient*( proc processNewBlockForLightClient*(
dag: ChainDAGRef, dag: ChainDAGRef,