From b0710806dad0807b98b73637c1261181888ffd66 Mon Sep 17 00:00:00 2001
From: Agnish Ghosh <iamagnix@gmail.com>
Date: Tue, 27 Aug 2024 14:28:38 +0530
Subject: [PATCH] added more logging

---
 beacon_chain/spec/eip7594_helpers.nim      | 12 +++++++-----
 beacon_chain/validators/message_router.nim |  9 ++-------
 2 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/beacon_chain/spec/eip7594_helpers.nim b/beacon_chain/spec/eip7594_helpers.nim
index 7384aaf0d..c7db8d88d 100644
--- a/beacon_chain/spec/eip7594_helpers.nim
+++ b/beacon_chain/spec/eip7594_helpers.nim
@@ -254,7 +254,7 @@ proc get_data_column_sidecars*(signed_block: deneb.TrustedSignedBeaconBlock |
       compute_signed_block_header(signed_block)
     kzg_incl_proof: array[4, Eth2Digest]
 
-  var sidecars: seq[DataColumnSidecar]
+  var sidecars = newSeq[DataColumnSidecar](CELLS_PER_EXT_BLOB)
 
   if cellsAndProofs.len == 0:
     return ok(sidecars)
@@ -264,9 +264,11 @@ proc get_data_column_sidecars*(signed_block: deneb.TrustedSignedBeaconBlock |
       column_cells: DataColumn
       column_proofs: KzgProofs
     for i in 0..<cellsAndProofs.len:
-      for j in 0 ..< CELLS_PER_EXT_BLOB:
-        column_cells[i] = cellsAndProofs[i].cells[j]
-        column_proofs[i] = cellsAndProofs[i].proofs[j]
+      discard column_cells.add(cellsAndProofs[i].cells)
+      discard column_proofs.add(cellsAndProofs[i].proofs)
+
+    debugEcho "column cells len"
+    debugEcho column_cells.len
 
     var sidecar = DataColumnSidecar(
       index: ColumnIndex(column_index),
@@ -291,7 +293,7 @@ proc get_data_column_sidecars*(signed_block: deneb.SignedBeaconBlock |
     signed_beacon_block_header = compute_signed_block_header(signed_block)
     kzg_incl_proof: array[4, Eth2Digest]
   
-  var sidecars: seq[DataColumnSidecar]
+  var sidecars = newSeq[DataColumnSidecar](CELLS_PER_EXT_BLOB)
 
   if blobs.len == 0:
     return ok(sidecars)
diff --git a/beacon_chain/validators/message_router.nim b/beacon_chain/validators/message_router.nim
index 38fb3261d..172d1cc84 100644
--- a/beacon_chain/validators/message_router.nim
+++ b/beacon_chain/validators/message_router.nim
@@ -173,13 +173,8 @@ proc routeSignedBeaconBlock*(
       debugEcho blobs.len
       debugEcho blobs.len
       if blobs.len != 0:
-        var cp: seq[CellsAndProofs]
-        for i in 0 ..< blobs.len:
-          let cells_and_proofs = computeCellsAndKzgProofs(KzgBlob(bytes: blobs[i].blob))
-          if not cells_and_proofs.isOk:
-            debug "Issue computing cells and proofs from blob payload"
-          cp.add(cells_and_proofs.get)
-        let dataColumnsOpt = newClone get_data_column_sidecars(blck, cp)
+        let dataColumnsOpt = 
+          newClone get_data_column_sidecars(blck, blobs.mapIt(KzgBlob(bytes: it.blob)))
         if not dataColumnsOpt[].isOk:
           debug "Issue with computing data column from blob bundle"
         let data_columns = dataColumnsOpt[].get()