status-im/nimbus-eth2
2
0
Fork 0
mirror of https://github.com/status-im/nimbus-eth2.git synced 2025-02-17 00:47:03 +00:00
Code Issues Projects Releases Wiki Activity

ensure LC runs exchangeTransitionConfiguration loop (#5312)

Browse Source 
In #4465, a regression was introduced by deleting the periodic call to
`engine_exchangeTransitionConfiguration` in the Nimbus light client.
This led to the light client never treating the EL as online and,
subsequently, not sending `engine_newPayload` requests for new blocks.
Strangely, `engine_forkchoiceUpdated` requests still make it through :)

Geth still requires both `engine_newPayload` and `fcU` to be called.
By restoring the `exchangeTransitionConfiguration` loop, `newPayload`
requests are once more issued to the EL.
This commit is contained in:
Etan Kissling 2023-08-18 11:30:02 +02:00 committed by GitHub
parent 38b1bafd87
commit 9a4a5d0f88
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
beacon_chain/el/el_manager.nim
View File

@ -2193,12 +2193,12 @@ proc startChainSyncingLoop(m: ELManager) {.async.} =
await syncedConnectionFut.cancelAndWait() await syncedConnectionFut.cancelAndWait()
syncedConnectionFut = m.selectConnectionForChainSyncing() syncedConnectionFut = m.selectConnectionForChainSyncing()
proc start*(m: ELManager) {.gcsafe.} = proc start*(m: ELManager, syncChain = true) {.gcsafe.} =
if m.elConnections.len == 0: if m.elConnections.len == 0:
return return
## Calling `ELManager.start()` on an already started ELManager is a noop ## Calling `ELManager.start()` on an already started ELManager is a noop
if m.chainSyncingLoopFut.isNil: if syncChain and m.chainSyncingLoopFut.isNil:
m.chainSyncingLoopFut = m.chainSyncingLoopFut =
m.startChainSyncingLoop() m.startChainSyncingLoop()

4
beacon_chain/nimbus_light_client.nim
View File

@ -138,6 +138,10 @@ programMain:
network, rng, config, cfg, forkDigests, getBeaconTime, network, rng, config, cfg, forkDigests, getBeaconTime,
genesis_validators_root, LightClientFinalizationMode.Optimistic) genesis_validators_root, LightClientFinalizationMode.Optimistic)
# Run `exchangeTransitionConfiguration` loop
if elManager != nil:
elManager.start(syncChain = false)
info "Listening to incoming network requests" info "Listening to incoming network requests"
network.initBeaconSync(cfg, forkDigests, genesisBlockRoot, getBeaconTime) network.initBeaconSync(cfg, forkDigests, genesisBlockRoot, getBeaconTime)
network.addValidator( network.addValidator(