From 9954da73d555007eb3f35042b10b998abc0c095a Mon Sep 17 00:00:00 2001 From: Agnish Ghosh Date: Thu, 3 Oct 2024 00:05:25 +0530 Subject: [PATCH] fix gossip val --- beacon_chain/gossip_processing/gossip_validation.nim | 2 -- beacon_chain/nimbus_beacon_node.nim | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/beacon_chain/gossip_processing/gossip_validation.nim b/beacon_chain/gossip_processing/gossip_validation.nim index f304529b0..c959dbcb3 100644 --- a/beacon_chain/gossip_processing/gossip_validation.nim +++ b/beacon_chain/gossip_processing/gossip_validation.nim @@ -522,8 +522,6 @@ proc validateDataColumnSidecar*( # (block_header.slot, block_header.proposer_index, blob_sidecar.index) # with valid header signature, sidecar inclusion proof, and kzg proof. let block_root = hash_tree_root(block_header) - if dag.getBlockRef(block_root).isSome(): - return errIgnore("DataColumnSidecar: already have block") if dataColumnQuarantine[].hasDataColumn( block_header.slot, block_header.proposer_index, data_column_sidecar.index): return errIgnore("DataColumnSidecar: already have valid data column from same proposer") diff --git a/beacon_chain/nimbus_beacon_node.nim b/beacon_chain/nimbus_beacon_node.nim index ea8634603..cf6c13254 100644 --- a/beacon_chain/nimbus_beacon_node.nim +++ b/beacon_chain/nimbus_beacon_node.nim @@ -1537,7 +1537,7 @@ proc tryReconstructingDataColumns* (self: BeaconNode, # storedColumn number is less than the NUMBER_OF_COLUMNS # then reconstruction is not possible, and if all the data columns # are already stored then we do not need to reconstruct at all - if not storedColumns.len < NUMBER_OF_COLUMNS div 2 and storedColumns.len != NUMBER_OF_COLUMNS: + if storedColumns.len < NUMBER_OF_COLUMNS div 2 and storedColumns.len != NUMBER_OF_COLUMNS: # Recover blobs from saved data column sidecars let recovered_cps = recover_cells_and_proofs(data_column_sidecars, storedColumns.len, signed_block) if not recovered_cps.isOk: