From 8eec6ab221fd8bd8a7a8fb987d618c096eb4fafd Mon Sep 17 00:00:00 2001
From: Etan Kissling <etan@status.im>
Date: Fri, 16 Jun 2023 14:15:42 +0200
Subject: [PATCH] avoid `ProveField` warning in `network_metadata` (#5066)

Before assigning to `genesisData` or returning `cfg`, have to check that
metadata is not `incompatible` to avoid `ProveField` warning.
The way how we use it was already correct (`incompatible` unreachable).
Use `case` syntax to silence the warning, and add comments referring to
the existing checks that make `incompatible` unreachable.
---
 beacon_chain/networking/network_metadata.nim | 37 +++++++++++++-------
 1 file changed, 25 insertions(+), 12 deletions(-)

diff --git a/beacon_chain/networking/network_metadata.nim b/beacon_chain/networking/network_metadata.nim
index 8bafa2e5e..ec83b7186 100644
--- a/beacon_chain/networking/network_metadata.nim
+++ b/beacon_chain/networking/network_metadata.nim
@@ -295,7 +295,11 @@ proc getMetadataForNetwork*(
   template withGenesis(metadata, genesis: untyped): untyped =
     when incbinEnabled:
       var tmp = metadata
-      assign(tmp.genesisData, genesis.toOpenArray(0, `genesis Size` - 1))
+      case tmp.incompatible
+      of false:
+        assign(tmp.genesisData, genesis.toOpenArray(0, `genesis Size` - 1))
+      of true:
+        raiseAssert "Unreachable"  # `loadCompileTimeNetworkMetadata`
       tmp
     else:
       metadata
@@ -343,15 +347,24 @@ proc getRuntimeConfig*(
   ## quite appropriate in such as low-level function. The "assume mainnet by
   ## default" behavior is something that should be handled closer to the `conf`
   ## layer.
-  if eth2Network.isSome:
-    return getMetadataForNetwork(eth2Network.get).cfg
+  let metadata =
+    if eth2Network.isSome:
+      getMetadataForNetwork(eth2Network.get)
+    else:
+      when const_preset == "mainnet":
+        mainnetMetadata
+      elif const_preset == "gnosis":
+        gnosisMetadata
+      else:
+        # This is a non-standard build (i.e. minimal), and the function was
+        # most likely executed in a test. The best we can do is return a fully
+        # default config:
+        return defaultRuntimeConfig
 
-  when const_preset == "mainnet":
-    mainnetMetadata.cfg
-  elif const_preset == "gnosis":
-    gnosisMetadata.cfg
-  else:
-    # This is a non-standard build (i.e. minimal), and the function was most
-    # likely executed in a test. The best we can do is return a fully default
-    # config:
-    defaultRuntimeConfig
+  return
+    case metadata.incompatible
+    of false:
+      metadata.cfg
+    of true:
+      # `getMetadataForNetwork` / `loadCompileTimeNetworkMetadata`
+      raiseAssert "Unreachable"