From 8ebd5a5fe8a11fa538982b6ed838b898e523f078 Mon Sep 17 00:00:00 2001
From: Miran <narimiran@disroot.org>
Date: Mon, 18 Jul 2022 21:17:11 +0200
Subject: [PATCH] fix some warnings (#3886)

---
 beacon_chain/beacon_chain_db_light_client.nim   | 2 --
 beacon_chain/validators/keystore_management.nim | 2 +-
 ncli/ncli_split_keystore.nim                    | 2 +-
 3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/beacon_chain/beacon_chain_db_light_client.nim b/beacon_chain/beacon_chain_db_light_client.nim
index fd6796e2a..8faa92266 100644
--- a/beacon_chain/beacon_chain_db_light_client.nim
+++ b/beacon_chain/beacon_chain_db_light_client.nim
@@ -11,8 +11,6 @@
 # protocol. See https://github.com/ethereum/consensus-specs/pull/2802
 
 import
-  # Standard library
-  std/os,
   # Status libraries
   chronicles,
   eth/db/kvstore_sqlite3,
diff --git a/beacon_chain/validators/keystore_management.nim b/beacon_chain/validators/keystore_management.nim
index 8f5881602..7dbcb140a 100644
--- a/beacon_chain/validators/keystore_management.nim
+++ b/beacon_chain/validators/keystore_management.nim
@@ -290,7 +290,7 @@ proc keyboardCreatePassword(prompt: string,
               "brute-force with automated tools. Please increase the " &
               "variety of the user characters."
         continue
-      elif password in mostCommonPasswords:
+      elif cstring(password) in mostCommonPasswords:
         echoP "The entered password is too commonly used and it would be " &
               "easy to brute-force with automated tools."
         echo ""
diff --git a/ncli/ncli_split_keystore.nim b/ncli/ncli_split_keystore.nim
index cbac76f59..d6f7e3ee5 100644
--- a/ncli/ncli_split_keystore.nim
+++ b/ncli/ncli_split_keystore.nim
@@ -1,6 +1,6 @@
 import
   std/os,
-  nimcrypto/utils, confutils, eth/keys,
+  confutils, eth/keys,
   ../beacon_chain/validators/keystore_management,
   ../beacon_chain/spec/[keystore, crypto],
   ../beacon_chain/conf