status-im
/
nimbus-eth2
mirror of https://github.com/status-im/nimbus-eth2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

only mark post-finalized blocks invalid (#4072)

This commit is contained in:
tersec 2022-09-06 11:43:19 +00:00 committed by GitHub
parent fb5d87f32a
commit 776f09215c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
beacon_chain/consensus_object_pools/blockchain_dag.nim
View File

@ -1515,14 +1515,14 @@ proc markBlockInvalid*(dag: ChainDAGRef, root: Eth2Digest) =
doAssert strictVerification notin dag.updateFlags
return
if root == dag.finalizedHead.blck.root:
if blck.slot <= dag.finalizedHead.slot:
# https://github.com/ethereum/consensus-specs/blob/v1.2.0-rc.3/sync/optimistic.md#re-orgs
# "If the justified checkpoint transitions from `NOT_VALIDATED` ->
# `INVALIDATED`, a consensus engine MAY choose to alert the user and force
# the application to exit."
#
# But be slightly less aggressive, and only check finalized.
warn "markBlockInvalid: finalized block invalidated"
warn "markBlockInvalid: attempted to mark finalized block invalidated"
doAssert strictVerification notin dag.updateFlags
return