use `nim-websock` instead of `news` (#4061)
`news` has a few open issues that are not present in `nim-websock`: 1. There is a 1 second delay between each MB of sent data. 2. Cancelling an ongoing `send` makes the entire WebSocket unusable. 3. Control packets do not have priority over ongoing message frames. Using `news`, there are quite a few of these messages in Geth: ``` Previously seen beacon client is offline. Please ensure it is operational to follow the chain! ``` It may take quite some time to reconnect when this happens. Using `nim-websock`, this message still occurs because `eth1_monitor` reconnects the EL connection when no new blocks occurred for 5 minutes, but reconnecting is quick and the message is rarer.
This commit is contained in:
parent
8fbb3d975b
commit
634408ff2c
|
@ -48,6 +48,8 @@ build/
|
||||||
|
|
||||||
test_keymanager_api
|
test_keymanager_api
|
||||||
|
|
||||||
|
/libnfuzz_linkerArgs.txt
|
||||||
|
|
||||||
# Prometheus db
|
# Prometheus db
|
||||||
/data
|
/data
|
||||||
# Grafana dashboards
|
# Grafana dashboards
|
||||||
|
|
|
@ -103,11 +103,6 @@
|
||||||
url = https://github.com/status-im/nim-json-rpc.git
|
url = https://github.com/status-im/nim-json-rpc.git
|
||||||
ignore = untracked
|
ignore = untracked
|
||||||
branch = master
|
branch = master
|
||||||
[submodule "vendor/news"]
|
|
||||||
path = vendor/news
|
|
||||||
url = https://github.com/status-im/news.git
|
|
||||||
ignore = untracked
|
|
||||||
branch = status
|
|
||||||
[submodule "vendor/nim-unicodedb"]
|
[submodule "vendor/nim-unicodedb"]
|
||||||
path = vendor/nim-unicodedb
|
path = vendor/nim-unicodedb
|
||||||
url = https://github.com/nitely/nim-unicodedb.git
|
url = https://github.com/nitely/nim-unicodedb.git
|
||||||
|
|
|
@ -0,0 +1 @@
|
||||||
|
-d:"json_rpc_websocket_package=websock"
|
|
@ -5,3 +5,5 @@
|
||||||
@if release:
|
@if release:
|
||||||
-d:"chronicles_line_numbers:0"
|
-d:"chronicles_line_numbers:0"
|
||||||
@end
|
@end
|
||||||
|
|
||||||
|
-d:"json_rpc_websocket_package=websock"
|
||||||
|
|
|
@ -5,3 +5,5 @@
|
||||||
@if release:
|
@if release:
|
||||||
-d:"chronicles_line_numbers:0"
|
-d:"chronicles_line_numbers:0"
|
||||||
@end
|
@end
|
||||||
|
|
||||||
|
-d:"json_rpc_websocket_package=websock"
|
||||||
|
|
|
@ -5,3 +5,5 @@
|
||||||
@if release:
|
@if release:
|
||||||
-d:"chronicles_line_numbers:0"
|
-d:"chronicles_line_numbers:0"
|
||||||
@end
|
@end
|
||||||
|
|
||||||
|
-d:"json_rpc_websocket_package=websock"
|
||||||
|
|
|
@ -1 +1,3 @@
|
||||||
-d:"chronicles_sinks=json[file(block_sim.log)]"
|
-d:"chronicles_sinks=json[file(block_sim.log)]"
|
||||||
|
|
||||||
|
-d:"json_rpc_websocket_package=websock"
|
||||||
|
|
|
@ -1,6 +1,8 @@
|
||||||
# Use only `secp256k1` public key cryptography as an identity in LibP2P.
|
# Use only `secp256k1` public key cryptography as an identity in LibP2P.
|
||||||
-d:"libp2p_pki_schemes=secp256k1"
|
-d:"libp2p_pki_schemes=secp256k1"
|
||||||
|
|
||||||
|
-d:"json_rpc_websocket_package=websock"
|
||||||
|
|
||||||
-d:chronosStrictException
|
-d:chronosStrictException
|
||||||
--styleCheck:usages
|
--styleCheck:usages
|
||||||
--styleCheck:hint
|
--styleCheck:hint
|
||||||
|
|
|
@ -1 +0,0 @@
|
||||||
Subproject commit 34272dedcd2586ba5b374a87c1f6d1adc6835049
|
|
|
@ -1 +1 @@
|
||||||
Subproject commit d618b555e791a4b1112a2fb1ca1c5c52960f0ae7
|
Subproject commit c8cbe08de756d65e7d085c409dfcb5edfba4aa5d
|
|
@ -1 +1 @@
|
||||||
Subproject commit 8a72c0f7690802753b1d59887745b1ce1f0c8b3d
|
Subproject commit 7b2ed397d6e4c37ea4df08ae82aeac7ff04cd180
|
Loading…
Reference in New Issue